From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin LABBE Subject: Re: [PATCH v2 1/1] drm: modes: fix DRM modes analysis regression Date: Wed, 9 Dec 2015 20:11:39 +0100 Message-ID: <56687CEB.9060007@gmail.com> References: <1449667811-24472-1-git-send-email-clabbe.montjoie@gmail.com> <1449667811-24472-2-git-send-email-clabbe.montjoie@gmail.com> <871tavwscq.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id A23D66E298 for ; Wed, 9 Dec 2015 11:11:44 -0800 (PST) Received: by wmvv187 with SMTP id v187so277563769wmv.1 for ; Wed, 09 Dec 2015 11:11:42 -0800 (PST) In-Reply-To: <871tavwscq.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula , airlied@linux.ie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org TGUgMDkvMTIvMjAxNSAxNjozMiwgSmFuaSBOaWt1bGEgYSDDqWNyaXQgOgo+IE9uIFdlZCwgMDkg RGVjIDIwMTUsIExBQkJFIENvcmVudGluIDxjbGFiYmUubW9udGpvaWVAZ21haWwuY29tPiB3cm90 ZToKPj4gTXkgbGF0ZXN0IGNvbW1pdCBpbnRyb2R1Y2Ugc29tZSBjYXNlIHdoZXJlIGEgdmFsaWQg bW9kZSwgY291bGQgYmUKPj4gcmVqZWN0ZWQuCj4+IHNpbXBsZV9zdHJ0b3ggZnVuY3Rpb25zIHN0 b3AgYXQgZmlyc3Qgbm9uLWRpZ2l0IGNoYXJhY3RlciwgYnV0IGtzdHJ0b3ggbm90Lgo+PiBTbyBh cmdzIGxpa2UgInZpZGVvPUhETUktQS0xOjcyMHg0ODAtMTZANjAiIHdpbGwgYmUgcmVqZWN0IHdo ZW4gY2hlY2tpbmcgMTZALgo+PiBUaGUgcHJvcGVyIHNvbHV0aW9uIGlzIHRvIHN0b3JlIGRpZ2l0 cyBpbiBhIHNwZWNpZmljIGJ1ZmZlci4KPiAKPiBPciB0byByZXZlcnQgcmVncmVzc2luZyBjb21t aXQuLi4/IFlvdXIgb3JpZ2luYWwgY29tbWl0IGNvbXBsaWNhdGVkIHRoZQo+IGFscmVhZHkgY29t cGxpY2F0ZWQgZnVuY3Rpb24sIGFuZCB0aGlzIG9uZSBtYWtlcyBpdCBtb3JlIHNvLiBXaGF0IGlz IHRoZQo+IGJlbmVmaXQ/Cj4gCgpUaGUgYmVuZWZpdCBpcyB0byByZW1vdmUgYSBmdW5jdGlvbiBt YXJrZWQgb2Jzb2xldGUgd2hvIGRvIG5vdCBzYWlkIGlmIHRoZSBjb252ZXJzYXRpb24gaXMgc3Vj Y2Vzc2Z1bCBvciBub3QuCkJ1dCBJIHVuZGVyc3RhbmQgdGhhdCB0aGUgd2F5IEkgaGF2ZSBkb25l IGl0IHdhcyBub3QgdGhlIGJlc3Qgb25lLgpJZiB0aGUgbWFpbnRhaW5lciB3YW50IGl0LCBJIHdp bGwgc2VuZCBhIHBhdGNoIGZvciByZXZlcnRpbmcgdGhlIGZpcnN0IHBhdGNoLgoKPj4gRml4ZXM6 IDUyMTU3YTRjYTM5NiAoImRybTogbW9kZXM6IHJlcGxhY2Ugc2ltcGxlX3N0cnRvdWwgYnkga3N0 cnRvdWludCIpCj4gCj4gRm9yIG1lIHRoZSBjb21taXQgaWQgaXMgY2MzNDQ5ODBjNzY3NDhlNTdj OWMwMzEwMGMyYTE0ZDM2YWIwMDMzNC4KCk91cHMsIEkgdG9vayBjb21taXQgaWQgZnJvbSBteSBs b2NhbCBnaXQuCgpSZWdhcmRzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbbLITLq (ORCPT ); Wed, 9 Dec 2015 14:11:46 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38311 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753561AbbLITLo (ORCPT ); Wed, 9 Dec 2015 14:11:44 -0500 Subject: Re: [PATCH v2 1/1] drm: modes: fix DRM modes analysis regression To: Jani Nikula , airlied@linux.ie References: <1449667811-24472-1-git-send-email-clabbe.montjoie@gmail.com> <1449667811-24472-2-git-send-email-clabbe.montjoie@gmail.com> <871tavwscq.fsf@intel.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Corentin LABBE X-Enigmail-Draft-Status: N1110 Message-ID: <56687CEB.9060007@gmail.com> Date: Wed, 9 Dec 2015 20:11:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <871tavwscq.fsf@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 09/12/2015 16:32, Jani Nikula a écrit : > On Wed, 09 Dec 2015, LABBE Corentin wrote: >> My latest commit introduce some case where a valid mode, could be >> rejected. >> simple_strtox functions stop at first non-digit character, but kstrtox not. >> So args like "video=HDMI-A-1:720x480-16@60" will be reject when checking 16@. >> The proper solution is to store digits in a specific buffer. > > Or to revert regressing commit...? Your original commit complicated the > already complicated function, and this one makes it more so. What is the > benefit? > The benefit is to remove a function marked obsolete who do not said if the conversation is successful or not. But I understand that the way I have done it was not the best one. If the maintainer want it, I will send a patch for reverting the first patch. >> Fixes: 52157a4ca396 ("drm: modes: replace simple_strtoul by kstrtouint") > > For me the commit id is cc344980c76748e57c9c03100c2a14d36ab00334. Oups, I took commit id from my local git. Regards