From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH v2] libxl: update check-xl-disk-parse Date: Wed, 9 Dec 2015 13:12:17 -0700 Message-ID: <56688B21.7000901@suse.com> References: <1449657816-5890-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a6l66-0002WA-3Q for xen-devel@lists.xenproject.org; Wed, 09 Dec 2015 20:12:22 +0000 In-Reply-To: <1449657816-5890-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 12/09/2015 03:43 AM, Wei Liu wrote: > The block-attach command now returns 1 when fails. Update first test > case to expect return value 1 instead of 255. > > The parser now doesn't generate output for default values. Remove them > from expected output. I made the same changes yesterday to get the tests to pass. > According to 417e6b70 ("libxl: add option for discard support to xl disk > configuration"), the "discard=" variant is never supported, delete two > test cases with that variant. Heh, I didn't realize "discard=" wasn't supported and instead added support for parsing it in libxlu_disk_l.l :-) Looks good to me. Tested-by: Jim Fehlig Regards, Jim