From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv6] 03/28] build: use generated Kconfig options for Xen Date: Wed, 9 Dec 2015 14:53:03 -0600 Message-ID: <566894AF.7080509@cardoe.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-4-git-send-email-cardoe@cardoe.com> <565C6F2402000078000BA43E@prv-mh.provo.novell.com> <56673554.7050309@cardoe.com> <5667F71F02000078000BD7A0@prv-mh.provo.novell.com> <56689038.8020000@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5740407357940212728==" Return-path: In-Reply-To: <56689038.8020000@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , Keir Fraser , Stefano Stabellini , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5740407357940212728== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2G8w2v17AQMmwhAf2RpJ2L8vUO6OiQ9h7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2G8w2v17AQMmwhAf2RpJ2L8vUO6OiQ9h7 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/9/15 2:34 PM, Doug Goldstein wrote: > On 12/9/15 2:40 AM, Jan Beulich wrote: >>>>> On 08.12.15 at 20:53, wrote: >>> On 11/30/15 8:45 AM, Jan Beulich wrote: >>>>>>> On 24.11.15 at 18:51, wrote: >>>>> @@ -227,9 +230,14 @@ kconfig :=3D silentoldconfig oldconfig config = menuconfig defconfig \ >>>>> $(kconfig): >>>>> $(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=3D$(XEN_TARGE= T_ARCH) $@ >>>>> =20 >>>>> -$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.c= onf.cmd >>>>> +$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.c= onf.cmd $(BASEDIR)/.config >>>>> $(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=3D$(XEN_T= ARGET_ARCH) silentoldconfig >>>>> =20 >>>>> # Allow people to just run `make` as before and not force them to = configure >>>>> -$(BASEDIR)/.config $(BASEDIR)/include/config/auto.conf.cmd: ; >>>>> +$(BASEDIR)/.config: >>>>> $(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=3D$(XEN_T= ARGET_ARCH) defconfig >>>> >>>> This should be one of the oldconfig targets now, shouldn't it? >>> >>> oldconfig uses .config. This is the case when the user has checked ou= t >>> the tree fresh. Its there to not change the workflow of "git clone ..= =2E >>> && cd xen/xen && make" >> >> Okay. But then this is meant to only support the simplest possible >> form, i.e. without honoring any make command line or ./.config >> overrides like debug=3Dy or kexec=3Dn? If that understanding of >> mine is correct, at least the comment should mention such a >> limitation (even better would be if in such cases unexpected >> results would be prevented by - as the most trivial solution - >> failing the build with a meaningful error message). >=20 > So you would like me to add code into xen/Makefile to detect if someone= > ran "make kexec=3DX" or added "kexec=3DX" into top level .config and gi= ve > them a meaningful error message to tell them to use "make config" inste= ad? So I need to clarify here. If you do want this, then do you have a suggestion how I can detect when someone uses the .config file to override this? $(origin) returns the same value for me in that case. For "make kexec=3Dn" I can detect that with $(origin). >=20 >> >>>>> +# Break the dependency chain for the first run >>>>> +$(BASEDIR)/include/config/auto.conf.cmd: ; >>>>> + >>>>> +-include $(BASEDIR)/include/config/auto.conf.cmd >>>> >>>> The comment is quite a bit different in Linux, and seems to make mor= e >>>> sense. Also note how Linux has an empty rule for $(KCONFIG_CONFIG), >>>> a variable which iirc you defined in an earlier patch and hence perh= aps >>>> you should be using here. >>> >>> I don't see where that's defined. >> >> "That" may have multiple meanings in this context. The empty >> rule is in ./Makefile: >=20 > "That" was KCONFIG_CONFIG. Which was not anywhere in this patchset and > was always .config. >=20 >> >> # To avoid any implicit rule to kick in, define an empty command >> $(KCONFIG_CONFIG) include/config/auto.conf.cmd: ; >> >> And if I was wrong with seeing you define KCONFIG_CONFIG >> somewhere, it would kind of imply that you probably should be >> inheriting this level of abstraction from Linux. >> >> Jan >> >=20 > Ok. I'll add a variable called KCONFIG_CONFIG. It'll default to .config= =2E > Arguably someone can override "make menuconfig > KCONFIG_CONFIG=3D/some/place/I/stored/my/config" in Linux which they ca= ll > "Load Alternate Config". Googling searching doesn't show this is a > commonly used option/behavior since people usually copy their .config i= n. >=20 > The other places this variable matters are in the building of the > dependencies in kbuild but Xen doesn't use kbuild. >=20 --=20 Doug Goldstein --2G8w2v17AQMmwhAf2RpJ2L8vUO6OiQ9h7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWaJSyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUNmkP/jGZhgCqrYMv9weBIQfBwKra DZOGY5Sk/4Mba/MMu7o4SQKpA26vDopt5W3miOIzl3omPALe4LM9PvLqfzRrciE9 +PxElqL2EwvU3aw8fEzhCkkpsWd13XR7bX+CGYxY4mWW7OnAWFogi0C29j8YBfXi QMY171cHO9RPCcxMaWvWd0hk13rR3m0BRgW4r968eIBOrZBPDHjU8NsTjNFvo9ni qaLGi+D9wjOmAzUulN0FK9v+LvpGFAGhoJx83hM38bw6jusp/gch4moEtZtLexu9 npeQFIx7kbOVS1ehAJPmSKYrfukwF8IYIbvrWnHDX2Q5n64t3YDT9BYK5mgymLcW 7AaKgbG7fKQ58Dj/9FEQDC9DubmHtnhNKWl5+ThkMCaDTfvVfSYb0+QO9J68DMz9 5dj3R5AFgRm05vH0R3FKXDlos9Sv6ci/9Q8By8lRkPjQlW0HeVTFLqAYkp2IuX6k wYa/WvfzIMUZb+dGs72zAm7WdZJ9c1I8d5Ql9uj38lYDRLCUZpRxO2lycqCDTCr0 IWcKnEQjiJtOTmXY0Bqj4QqJ25aQzoTX8kq2Pczv4SMHXtQXNITnIimNKZ4G+nhY N2etGpnkzWjecVV8LwRQfOcG2Ivlu5XSfVWQ0ZmhPjKVOqbQhKfMWWlBh/8kMb50 WyGMmjROLPUEmY5K4sIg =O2up -----END PGP SIGNATURE----- --2G8w2v17AQMmwhAf2RpJ2L8vUO6OiQ9h7-- --===============5740407357940212728== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5740407357940212728==--