From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752941AbbLIVFD (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 16:05:03 -0500
Received: from mga01.intel.com ([192.55.52.88]:43824 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751321AbbLIVFB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 16:05:01 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,405,1444719600"; 
   d="scan'208";a="870332859"
Subject: Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU
 support
To: Peter Zijlstra <peterz@infradead.org>
References: <872e8ef16cfc38e5ff3b45fac1094e6f1722e4ad.1449470704.git.harish.chegondi@intel.com>
 <8ac513981264c3eb10343a3f523f19cc5a2d12fe.1449470704.git.harish.chegondi@intel.com>
 <20151208090722.GH6356@twins.programming.kicks-ass.net>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
        Harish Chegondi <harish.chegondi@gmail.com>,
        Andi Kleen <andi.kleen@intel.com>, Kan Liang <kan.liang@intel.com>,
        Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
From: Harish Chegondi <harish.chegondi@intel.com>
Message-ID: <5668972F.5030805@intel.com>
Date: Wed, 9 Dec 2015 13:03:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151208090722.GH6356@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 12/08/2015 01:07 AM, Peter Zijlstra wrote:
> On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote:
>> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void)
>>  		break;
>>  	case 61: /* Broadwell */
>>  		ret = bdw_uncore_pci_init();
>> +	case 87: /* Knights Landing */
>> +		ret = knl_uncore_pci_init();
>>  		break;
>>  	default:
>>  		return 0;
>> @@ -1289,6 +1300,8 @@ static int __init uncore_cpu_init(void)
>>  		break;
>>  	case 86: /* BDX-DE */
>>  		bdx_uncore_cpu_init();
>> +	case 87: /* Knights Landing */
>> +		knl_uncore_cpu_init();
>>  		break;
>>  	default:
> Surely you need some extra break statements in there?
> .
>
Yes, I missed the break statements. I will add the breaks in the next version of the patch.

Thanks for the review!

-Harish.