Re: [PATCH libibverbs] init.c: increase sysfs read buffer size to 16

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On 12/09/2015 10:05 AM, Jeff Squyres (jsquyres) wrote:
> Any further comments on this?
> 
> Doug -- does it look ok to you?
> 
> 
>> On Dec 7, 2015, at 5:27 AM, Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
>>
>> On 12/04/2015 01:09 AM, Jeff Squyres wrote:
>>> The default value of 8 is too small to read
>>> /sys/class/infiniband/usnic_x/node_type, which contains "6: usNIC
>>> UDP".  Per a7a73a8c1b39362f1701256bc772d82847832f9c, the too-small
>>> buffer causes a stderr warning to be emitted from ibv_devinfo when
>>> reading usNIC devices.
>>>
>>> This commit therefore increases the buffer size to 16, which is long
>>> enough to read the usNIC node_type value.
>>
>> Reviewed-by: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> 

Yeah, looks fine to me.  I'll pull it in shortly.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]