From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a6n9D-0002re-Pp
	for qemu-devel@nongnu.org; Wed, 09 Dec 2015 17:23:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a6n9A-0001Qu-Jj
	for qemu-devel@nongnu.org; Wed, 09 Dec 2015 17:23:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43376)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a6n9A-0001Qm-E3
	for qemu-devel@nongnu.org; Wed, 09 Dec 2015 17:23:40 -0500
References: <1449691029-15525-1-git-send-email-ashok.raj@intel.com>
	<1449691029-15525-2-git-send-email-ashok.raj@intel.com>
	<56689824.7030203@redhat.com>
	<20151209230504.GB15886@otc-brkl-03.jf.intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5668A9E0.2040109@redhat.com>
Date: Wed, 9 Dec 2015 23:23:28 +0100
MIME-Version: 1.0
In-Reply-To: <20151209230504.GB15886@otc-brkl-03.jf.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Patch V0] x86,
	mce: Basic support to add LMCE support to QEMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: Tony Luck <tony.luck@intel.com>, Eduardo Habkost <ehabkost@redhat.com>, Gleb Natapov <gleb@kernel.org>, qemu-devel@nongnu.org, Gong Chen <gong.chen@intel.com>, Andi Kleen <andi.kleen@intel.com>, Boris Petkov <bp@suse.de>



On 10/12/2015 00:05, Raj, Ashok wrote:
>>> > > +    /*
>>> > > +     * We need to read back the value of MSREXT_MCG_CTL that was set by the
>>> > > +     * guest kernel back into Qemu
>>> > > +     */
>>> > > +    cs->kvm_vcpu_dirty = false;
>>> > > +    cpu_synchronize_state(cs);
> This wasn't in my original patch, but was found required.
> 
> Will have Gong check this and report back.

The cpu_synchronize_state is okay, the other part shouldn't be necessary
though.

Paolo