From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6rLS-0007ff-37 for qemu-devel@nongnu.org; Wed, 09 Dec 2015 21:52:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6rLN-0004F8-UV for qemu-devel@nongnu.org; Wed, 09 Dec 2015 21:52:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6rLN-0004F1-Pa for qemu-devel@nongnu.org; Wed, 09 Dec 2015 21:52:33 -0500 References: <1449708810-17891-1-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <5668E8F0.4060202@redhat.com> Date: Wed, 9 Dec 2015 19:52:32 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eGdoXPrlokSfmdf8uSVglxGl7RN1mRrvS" Subject: Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , QEMU This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eGdoXPrlokSfmdf8uSVglxGl7RN1mRrvS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/09/2015 05:57 PM, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Thu, Dec 10, 2015 at 1:53 AM, wrote: >> From: Marc-Andr=C3=A9 Lureau >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck)= >> >=20 > A subsidiary question is whether qemu really care about using POSIX > shell, or we can just depend on bashism. That would help with > simplifying some Makefile lines too. Debian uses dash, not bash, as /bin/sh. As both 'configure' and 'Makefile' depend on '/bin/sh', then yes, we care about POSIX compliance.= Only in scripts that explicitly require /bin/bash, such as much of the scripts under tests/, can we get away with bashisms. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eGdoXPrlokSfmdf8uSVglxGl7RN1mRrvS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWaOjwAAoJEKeha0olJ0NqxhwH/ixEsaJwmw/KWR7xX2gFQPJc 6OYS1Li6P49Nr3Ye3w/jMrK7AlLLXHKYrUXxXIdMarYlzpBBNO7qhNAf5T4aMhm2 yVKqYVDB70fHEccWO2zJrJ5i1Ca1AdeXIsv0+txmgQ9ONyVWWOro6tK/2ruNfAt8 b1NTh+1h3M/UC2X3aJ4n19m6VaUZt1dA7PnG13nqZJzwbGgxPoA4l0cUI3WT0L0V /DQhZ1v6VjkRGINkV9lp8HlcluHqDOge+b9EPZ4YzJxhiDj2yB5Gw+P9Dwhr7W5A hmDkpljh3JF3Xn63yqxUnP/PLFcGSz+r00D+FyEDeJJvCeNsstdenNpTi3Ez0hA= =wdXD -----END PGP SIGNATURE----- --eGdoXPrlokSfmdf8uSVglxGl7RN1mRrvS--