All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find
Date: Wed, 04 Jul 2012 14:17:44 +0200	[thread overview]
Message-ID: <5668cb98eebb0a27530c.1341404264@probook.site> (raw)

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1341404234 -7200
# Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
# Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
libxl: fix unitialized variables in libxl__primary_console_find

gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
LIBXL_DOMAIN_TYPE_INVALID properly:

cc1: warnings being treated as errors
libxl.c: In function 'libxl_primary_console_exec':
libxl.c:1408:14: error: 'domid' may be used uninitialized in this function
libxl.c:1409:9: error: 'cons_num' may be used uninitialized in this function
libxl.c:1410:24: error: 'type' may be used uninitialized in this function
libxl.c: In function 'libxl_primary_console_get_tty':
libxl.c:1421:14: error: 'domid' may be used uninitialized in this function
libxl.c:1422:9: error: 'cons_num' may be used uninitialized in this function
libxl.c:1423:24: error: 'type' may be used uninitialized in this function
make[3]: *** [libxl.o] Error 1

Fix this by adding a default case.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 42f76d536b11 -r 5668cb98eebb tools/libxl/libxl.c
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -1392,6 +1392,7 @@ static int libxl__primary_console_find(l
             *type = LIBXL_CONSOLE_TYPE_PV;
             break;
         case LIBXL_DOMAIN_TYPE_INVALID:
+        default:
             rc = ERROR_INVAL;
             goto out;
         }

             reply	other threads:[~2012-07-04 12:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 12:17 Olaf Hering [this message]
2012-07-23 10:51 ` [PATCH] libxl: fix unitialized variables in libxl__primary_console_find Ian Campbell
2012-07-23 13:43   ` Olaf Hering
2012-07-24  8:45     ` Ian Campbell
2012-07-30 19:04       ` Olaf Hering
  -- strict thread matches above, loose matches on Subject: below --
2012-07-30 16:35 Olaf Hering
2012-08-01 11:47 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5668cb98eebb0a27530c.1341404264@probook.site \
    --to=olaf@aepfle.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.