From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhu Lingshan <lszhu@suse.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: pl@kamp.de, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent
Date: Thu, 10 Dec 2015 09:55:40 +0100 [thread overview]
Message-ID: <56693E0C.8000003@redhat.com> (raw)
In-Reply-To: <1449716386-5652-1-git-send-email-lszhu@suse.com>
On 10/12/2015 03:59, Zhu Lingshan wrote:
> - if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> + if ((rc16 != NULL) && ((task == NULL) || (task->status != SCSI_STATUS_GOOD))) {
> + error_setg(errp, "iSCSI: failed to send readcapacity16 command.");
> + }
You need an "else" here.
Paolo
> + if ((rc10 != NULL) && ((task == NULL) || (task->status != SCSI_STATUS_GOOD))) {
> error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> } else if (!iscsilun->block_size ||
next prev parent reply other threads:[~2015-12-10 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:59 [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent Zhu Lingshan
2015-12-10 8:55 ` Paolo Bonzini [this message]
2015-12-10 8:57 ` Peter Lieven
2015-12-10 9:08 ` Zhu Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56693E0C.8000003@redhat.com \
--to=pbonzini@redhat.com \
--cc=lszhu@suse.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.