From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration Date: Thu, 10 Dec 2015 13:49:31 +0200 Message-ID: <566966CB.4080700@mellanox.com> References: <20151207204046.8144.18752.stgit@phlsvslse11.ph.intel.com> <20151207204300.8144.20089.stgit@phlsvslse11.ph.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151207204300.8144.20089.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Marciniszyn , Ira Weiny List-Id: linux-rdma@vger.kernel.org On 07/12/2015 22:43, Dennis Dalessandro wrote: > +struct rvt_dev_info { > + struct ib_device ibdev; > + int (*port_callback)(struct ib_device *, u8, struct kobject *); > + > + /* > + * TODO: > + * need to reflect module parameters that may vary by dev > + */ > +}; Could you explain what you mean by the TODO comment? Different device drivers using rvt will have their own modules with their own parameters, right? Why do you need them reflected here? Thanks, Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html