All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: linux-can@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
	bhupesh.sharma@freescale.com
Subject: Re: [PATCH v2 00/11] RFC: cleanup flexcan driver, introduce and make use of IRQ offloading
Date: Thu, 10 Dec 2015 15:04:29 +0100	[thread overview]
Message-ID: <5669866D.9030100@pengutronix.de> (raw)
In-Reply-To: <CAOpc7mGK9WEnbowHJONbP-szW7mVQbU46uUPXF8V09omqWLQMA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

On 12/10/2015 02:52 PM, Holger Schurig wrote:
> Why did you invent your own rx-fifo.c/.h and didn't reuse the kernel's
> fifo, kfifo ?

Good question. We actually make use of the kernel circular buffer
(linux/circ_buf.h). However, it seems we need a more powerful data
structure anyways, e.g. list sorted by timestamp (with some magic taking
care of the limited width of the timestamp register).

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2015-12-10 14:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 12:33 [PATCH v2 00/11] RFC: cleanup flexcan driver, introduce and make use of IRQ offloading Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 01/11] can: flexcan: calculate default value for imask1 during runtime Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 02/11] can: flexcan: make TX mailbox selectable " Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 03/11] can: rx-fifo: Add support for simple irq offloading Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 04/11] can: flexcan: make use of rx-fifo's irq_offload_simple Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 05/11] can: flexcan: add missing register definitions Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 06/11] can: flexcan: activate individual RX masking and initialize reg_rximr Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 07/11] can: flexcan: add quirk FLEXCAN_QUIRK_ENABLE_EACEN_RRS Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 08/11] can: flexcan: reg_imask2_default Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 09/11] can: rx-fifo: introduce software rx-fifo implementation Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 10/11] can: flexcan: add support for rx-fifo based software FIFO implementation Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 11/11] can: flexcan: switch imx6 and vf610 to software based fifo Marc Kleine-Budde
     [not found] ` <CAOpc7mGK9WEnbowHJONbP-szW7mVQbU46uUPXF8V09omqWLQMA@mail.gmail.com>
2015-12-10 14:04   ` Marc Kleine-Budde [this message]
2016-01-18 11:14 ` [PATCH v2 00/11] RFC: cleanup flexcan driver, introduce and make use of IRQ offloading Holger Schurig
2016-01-18 22:04   ` Marc Kleine-Budde
2016-01-19  0:26     ` Tom Evans
2016-02-22 15:16       ` Mirza Krak
2016-02-22 15:19         ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5669866D.9030100@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=bhupesh.sharma@freescale.com \
    --cc=holgerschurig@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.