From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Price <anprice@redhat.com>
Date: Thu, 10 Dec 2015 14:19:55 +0000
Subject: [Cluster-devel] [PATCH] mkfs.gfs2: Always validate the
 locktable option
In-Reply-To: <2007062394.31800161.1449753620789.JavaMail.zimbra@redhat.com>
References: <1449752726-28341-1-git-send-email-anprice@redhat.com>
	<2007062394.31800161.1449753620789.JavaMail.zimbra@redhat.com>
Message-ID: <56698A0B.1010609@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi Bob,

On 10/12/15 13:20, Bob Peterson wrote:
> Hi Andy,
>
> The patch looks good. The only thing that caught my eye was that
> this statement looks kinda messy and could use a few more parentheses:
>
> (snip)
>> +	if (strcmp(opts->lockproto, "lock_nolock") != 0 && !table_required)
>
> The logic looks right, but I usually add more parens than necessary, for clarity.

Fair point. Changed and pushed.

Thanks!
Andy