All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
	jbeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] scripts: Add a script to build and submit to coverity.
Date: Thu, 10 Dec 2015 17:52:52 +0000	[thread overview]
Message-ID: <5669BBF4.1000305@citrix.com> (raw)
In-Reply-To: <22121.47872.686135.711210@mariner.uk.xensource.com>

On 10/12/15 17:48, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH] scripts: Add a script to build and submit to coverity."):
>> On 10/12/15 16:53, Ian Campbell wrote:
>>> ijc: Maybe we can think of a way to add this to osstest while still
>>> keeping the coverity token private?
>> This would be ideal.
> It doesn't sound particularly hard, apart from this wrinkle.
>
>>> +# Set $COV_EMAIL and $COV_TOKEN to credentials, otherwise it will
> ...
>>> +    declare -a curl_args
>>> +    curl_args+=("--form" "token=$COV_TOKEN")
>>> +    curl_args+=("--form" "email=$COV_EMAIL")
>>> +    curl_args+=("--form" "file=@$COV_TARBALL")
>>> +    curl_args+=("--form" "version=$COV_VERSION")
>>> +    curl_args+=("--form" "description=$COV_HEAD")
>>> +    curl_args+=("https://scan.coverity.com/builds?project=XenProject")
> Is there a way to do this that does not involve the authentication
> token being passed on curl's command line ?
>
> Ideally there would be a way to get it to read the token from a file
> in $HOME.  We could then provide the token in ~osstest in the
> production colo.

One way or another, the authentication token needs to be in a post
header.  How this script and `curl` make it happen is open to improvement.

Perhaps something like this? (Completely untested)

--form token=@~osstest/coverity-secret-token

~Andrew

  reply	other threads:[~2015-12-10 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 16:53 [PATCH] scripts: Add a script to build and submit to coverity Ian Campbell
2015-12-10 17:01 ` Jan Beulich
2015-12-10 17:07 ` Andrew Cooper
2015-12-10 17:48   ` Ian Jackson
2015-12-10 17:52     ` Andrew Cooper [this message]
2015-12-10 18:02       ` Ian Jackson
2015-12-10 18:06         ` Ian Jackson
2015-12-10 18:10           ` Andrew Cooper
2015-12-14 13:50           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5669BBF4.1000305@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.