From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] scripts: Add a script to build and submit to coverity. Date: Thu, 10 Dec 2015 18:10:45 +0000 Message-ID: <5669C025.7000608@citrix.com> References: <1449766401-31434-1-git-send-email-ian.campbell@citrix.com> <5669B155.2010905@citrix.com> <22121.47872.686135.711210@mariner.uk.xensource.com> <5669BBF4.1000305@citrix.com> <22121.48720.50110.370659@mariner.uk.xensource.com> <22121.48926.249211.58296@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22121.48926.249211.58296@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Ian Campbell , jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 10/12/15 18:06, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH] scripts: Add a script to build and submit to coverity."): >> If curl can do that then fine. Given >> >>>>>> + declare -a curl_args >>>>>> + curl_args+=("--form" "token=$COV_TOKEN") >>>>>> + curl_args+=("--form" "email=$COV_EMAIL") >> this could be achieved by having ts-do-coverity-thing set COV_TOKEN to >> $HOME/.xen-osstest/coverity-secret or whatever. ts-do-coverity-thing >> would need to set a bunch of other COV_SOMETHING anyay. > It occurs to me that it would be better if > - the Coverity token did not have to be sent to the build host, > but could remain on the controller > - the Coverity log file thing could be left in the build logs > > But I don't think this means that your script ought not to have an > `upload' function. It just means that maybe osstest will need what > amounts to a copy of it. The build() part of this script creates xen-coverity-$HEAD-SHA.tgz which contains everything wanted by Coverity, other than the metadata used to correctly submit it to their cloud. OSSTest could definitely scoop that file (~140mb iirc) and submit it from the controller instead of the build host. ~Andrew