From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 5/6] drm/i915: Support for pread/pwrite from/to non shmem backed objects Date: Thu, 10 Dec 2015 18:18:28 +0000 Message-ID: <5669C1F4.1010300@intel.com> References: <1449665182-10054-1-git-send-email-ankitprasad.r.sharma@intel.com> <1449665182-10054-6-git-send-email-ankitprasad.r.sharma@intel.com> <56685395.8040806@linux.intel.com> <5668838C.6060101@intel.com> <1449745976.12247.84.camel@ankitprasad-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 411CE7A1A2 for ; Thu, 10 Dec 2015 10:18:31 -0800 (PST) In-Reply-To: <1449745976.12247.84.camel@ankitprasad-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ankitprasad Sharma Cc: intel-gfx@lists.freedesktop.org, akash.goel@intel.com, shashidhar.hiremath@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMTIvMTUgMTE6MTIsIEFua2l0cHJhc2FkIFNoYXJtYSB3cm90ZToKPiBPbiBXZWQsIDIw MTUtMTItMDkgYXQgMTk6MzkgKzAwMDAsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBPbiAwOS8xMi8x NSAxNjoxNSwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Pgo+Pj4gSGksCj4+Pgo+Pj4gT24gMDkv MTIvMTUgMTI6NDYsIGFua2l0cHJhc2FkLnIuc2hhcm1hQGludGVsLmNvbSB3cm90ZToKPj4+PiBG cm9tOiBBbmtpdHByYXNhZCBTaGFybWEgPGFua2l0cHJhc2FkLnIuc2hhcm1hQGludGVsLmNvbT4K Pj4+Pgo+Pj4+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBleHRlbmRpbmcgdGhlIHByZWFk L3B3cml0ZSBmdW5jdGlvbmFsaXR5Cj4+Pj4gZm9yIG9iamVjdHMgbm90IGJhY2tlZCBieSBzaG1l bS4gVGhlIGFjY2VzcyB3aWxsIGJlIG1hZGUgdGhyb3VnaAo+Pj4+IGd0dCBpbnRlcmZhY2UuIFRo aXMgd2lsbCBjb3ZlciBvYmplY3RzIGJhY2tlZCBieSBzdG9sZW4gbWVtb3J5IGFzIHdlbGwKPj4+ PiBhcyBvdGhlciBub24tc2htZW0gYmFja2VkIG9iamVjdHMuCj4+Pj4KPj4+PiB2MjogRHJvcCBs b2NrcyBhcm91bmQgc2xvd191c2VyX2FjY2VzcywgcHJlZmF1bHQgdGhlIHBhZ2VzIGJlZm9yZQo+ Pj4+IGFjY2VzcyAoQ2hyaXMpCj4+Pj4KPj4+PiB2MzogUmViYXNlZCB0byB0aGUgbGF0ZXN0IGRy bS1pbnRlbC1uaWdodGx5IChBbmtpdCkKPj4+Pgo+Pj4+IHY0OiBNb3ZlZCBwYWdlIGJhc2UgJiBv ZmZzZXQgY2FsY3VsYXRpb25zIG91dHNpZGUgdGhlIGNvcHkgbG9vcCwKPj4+PiBjb3JyZWN0ZWQg ZGF0YSB0eXBlcyBmb3Igc2l6ZSBhbmQgb2Zmc2V0IHZhcmlhYmxlcywgY29ycmVjdGVkIGlmLWVs c2UKPj4+PiBicmFjZXMgZm9ybWF0IChUdnJ0a28va2VybmVsZG9jcykKPj4+Pgo+Pj4+IHY1OiBF bmFibGVkIHByZWFkL3B3cml0ZSBmb3IgYWxsIG5vbi1zaG1lbSBiYWNrZWQgb2JqZWN0cyBpbmNs dWRpbmcKPj4+PiB3aXRob3V0IHRpbGluZyByZXN0cmljdGlvbnMgKEFua2l0KQo+Pj4+Cj4+Pj4g djY6IFVzaW5nIHB3cml0ZV9mYXN0IGZvciBub24tc2htZW0gYmFja2VkIG9iamVjdHMgYXMgd2Vs bCAoQ2hyaXMpCj4+Pj4KPj4+PiB2NzogVXBkYXRlZCBjb21taXQgbWVzc2FnZSwgUmVuYW1lZCBp OTE1X2dlbV9ndHRfcmVhZCB0bwo+Pj4+IGk5MTVfZ2VtX2d0dF9jb3B5LAo+Pj4+IGFkZGVkIHB3 cml0ZSBzbG93IHBhdGggZm9yIG5vbi1zaG1lbSBiYWNrZWQgb2JqZWN0cyAoQ2hyaXMvVHZydGtv KQo+Pj4+Cj4+Pj4gdjg6IFVwZGF0ZWQgdjcgY29tbWl0IG1lc3NhZ2UsIG11dGV4IHVubG9jayBh cm91bmQgcHdyaXRlIHNsb3cgcGF0aCBmb3IKPj4+PiBub24tc2htZW0gYmFja2VkIG9iamVjdHMg KFR2cnRrbykKPj4+Pgo+Pj4+IFRlc3RjYXNlOiBpZ3QvZ2VtX3N0b2xlbgo+Pj4+Cj4+Pj4gU2ln bmVkLW9mZi1ieTogQW5raXRwcmFzYWQgU2hhcm1hIDxhbmtpdHByYXNhZC5yLnNoYXJtYUBpbnRl bC5jb20+Cj4+Pj4gLS0tCj4+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8 IDE1MQo+Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPj4+PiAg ICAxIGZpbGUgY2hhbmdlZCwgMTI3IGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+Pj4+ Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+PiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+PiBpbmRleCBlZDk3ZGU2Li42OGVk NjdhIDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+Pj4gQEAgLTYxNCw2ICs2 MTQsOTkgQEAgc2htZW1fcHJlYWRfc2xvdyhzdHJ1Y3QgcGFnZSAqcGFnZSwgaW50Cj4+Pj4gc2ht ZW1fcGFnZV9vZmZzZXQsIGludCBwYWdlX2xlbmd0aCwKPj4+PiAgICAgICAgcmV0dXJuIHJldCA/ IC0gRUZBVUxUIDogMDsKPj4+PiAgICB9Cj4+Pj4KPj4+PiArc3RhdGljIGlubGluZSB1aW50NjRf dAo+Pj4+ICtzbG93X3VzZXJfYWNjZXNzKHN0cnVjdCBpb19tYXBwaW5nICptYXBwaW5nLAo+Pj4+ ICsgICAgICAgICB1aW50NjRfdCBwYWdlX2Jhc2UsIGludCBwYWdlX29mZnNldCwKPj4+PiArICAg ICAgICAgY2hhciBfX3VzZXIgKnVzZXJfZGF0YSwKPj4+PiArICAgICAgICAgaW50IGxlbmd0aCwg Ym9vbCBwd3JpdGUpCj4+Pj4gK3sKPj4+PiArICAgIHZvaWQgX19pb21lbSAqdmFkZHJfaW5hdG9t aWM7Cj4+Pj4gKyAgICB2b2lkICp2YWRkcjsKPj4+PiArICAgIHVpbnQ2NF90IHVud3JpdHRlbjsK Pj4+PiArCj4+Pj4gKyAgICB2YWRkcl9pbmF0b21pYyA9IGlvX21hcHBpbmdfbWFwX3djKG1hcHBp bmcsIHBhZ2VfYmFzZSk7Cj4+Pj4gKyAgICAvKiBXZSBjYW4gdXNlIHRoZSBjcHUgbWVtIGNvcHkg ZnVuY3Rpb24gYmVjYXVzZSB0aGlzIGlzIFg4Ni4gKi8KPj4+PiArICAgIHZhZGRyID0gKHZvaWQg X19mb3JjZSAqKXZhZGRyX2luYXRvbWljICsgcGFnZV9vZmZzZXQ7Cj4+Pj4gKyAgICBpZiAocHdy aXRlKQo+Pj4+ICsgICAgICAgIHVud3JpdHRlbiA9IF9fY29weV9mcm9tX3VzZXIodmFkZHIsIHVz ZXJfZGF0YSwgbGVuZ3RoKTsKPj4+PiArICAgIGVsc2UKPj4+PiArICAgICAgICB1bndyaXR0ZW4g PSBfX2NvcHlfdG9fdXNlcih1c2VyX2RhdGEsIHZhZGRyLCBsZW5ndGgpOwo+Pj4+ICsKPj4+PiAr ICAgIGlvX21hcHBpbmdfdW5tYXAodmFkZHJfaW5hdG9taWMpOwo+Pj4+ICsgICAgcmV0dXJuIHVu d3JpdHRlbjsKPj4+PiArfQo+Pj4+ICsKPj4+PiArc3RhdGljIGludAo+Pj4+ICtpOTE1X2dlbV9n dHRfY29weShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+Pj4+ICsgICAgICAgICAgIHN0cnVjdCBk cm1faTkxNV9nZW1fb2JqZWN0ICpvYmosIHVpbnQ2NF90IHNpemUsCj4+Pj4gKyAgICAgICAgICAg dWludDY0X3QgZGF0YV9vZmZzZXQsIHVpbnQ2NF90IGRhdGFfcHRyKQo+Pj4+ICt7Cj4+Pj4gKyAg ICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ Pj4+ICsgICAgY2hhciBfX3VzZXIgKnVzZXJfZGF0YTsKPj4+PiArICAgIHVpbnQ2NF90IHJlbWFp bjsKPj4+PiArICAgIHVpbnQ2NF90IG9mZnNldCwgcGFnZV9iYXNlOwo+Pj4+ICsgICAgaW50IHBh Z2Vfb2Zmc2V0LCBwYWdlX2xlbmd0aCwgcmV0ID0gMDsKPj4+PiArCj4+Pj4gKyAgICByZXQgPSBp OTE1X2dlbV9vYmpfZ2d0dF9waW4ob2JqLCAwLCBQSU5fTUFQUEFCTEUpOwo+Pj4+ICsgICAgaWYg KHJldCkKPj4+PiArICAgICAgICBnb3RvIG91dDsKPj4+PiArCj4+Pj4gKyAgICByZXQgPSBpOTE1 X2dlbV9vYmplY3Rfc2V0X3RvX2d0dF9kb21haW4ob2JqLCBmYWxzZSk7Cj4+Pj4gKyAgICBpZiAo cmV0KQo+Pj4+ICsgICAgICAgIGdvdG8gb3V0X3VucGluOwo+Pj4+ICsKPj4+PiArICAgIHJldCA9 IGk5MTVfZ2VtX29iamVjdF9wdXRfZmVuY2Uob2JqKTsKPj4+PiArICAgIGlmIChyZXQpCj4+Pj4g KyAgICAgICAgZ290byBvdXRfdW5waW47Cj4+Pj4gKwo+Pj4+ICsgICAgdXNlcl9kYXRhID0gdG9f dXNlcl9wdHIoZGF0YV9wdHIpOwo+Pj4+ICsgICAgcmVtYWluID0gc2l6ZTsKPj4+PiArICAgIG9m ZnNldCA9IGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChvYmopICsgZGF0YV9vZmZzZXQ7Cj4+Pj4g Kwo+Pj4+ICsgICAgbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4+Pj4gKyAgICBp ZiAobGlrZWx5KCFpOTE1LnByZWZhdWx0X2Rpc2FibGUpKQo+Pj4+ICsgICAgICAgIHJldCA9IGZh dWx0X2luX211bHRpcGFnZXNfd3JpdGVhYmxlKHVzZXJfZGF0YSwgcmVtYWluKTsKPj4+PiArCj4+ Pj4gKyAgICAvKgo+Pj4+ICsgICAgICogcGFnZV9vZmZzZXQgPSBvZmZzZXQgd2l0aGluIHBhZ2UK Pj4+PiArICAgICAqIHBhZ2VfYmFzZSA9IHBhZ2Ugb2Zmc2V0IHdpdGhpbiBhcGVydHVyZQo+Pj4+ ICsgICAgICovCj4+Pj4gKyAgICBwYWdlX29mZnNldCA9IG9mZnNldF9pbl9wYWdlKG9mZnNldCk7 Cj4+Pj4gKyAgICBwYWdlX2Jhc2UgPSBvZmZzZXQgJiBQQUdFX01BU0s7Cj4+Pj4gKwo+Pj4+ICsg ICAgd2hpbGUgKHJlbWFpbiA+IDApIHsKPj4+PiArICAgICAgICAvKiBwYWdlX2xlbmd0aCA9IGJ5 dGVzIHRvIGNvcHkgZm9yIHRoaXMgcGFnZSAqLwo+Pj4+ICsgICAgICAgIHBhZ2VfbGVuZ3RoID0g cmVtYWluOwo+Pj4+ICsgICAgICAgIGlmICgocGFnZV9vZmZzZXQgKyByZW1haW4pID4gUEFHRV9T SVpFKQo+Pj4+ICsgICAgICAgICAgICBwYWdlX2xlbmd0aCA9IFBBR0VfU0laRSAtIHBhZ2Vfb2Zm c2V0Owo+Pj4+ICsKPj4+PiArICAgICAgICAvKiBUaGlzIGlzIGEgc2xvdyByZWFkL3dyaXRlIGFz IGl0IHRyaWVzIHRvIHJlYWQgZnJvbQo+Pj4+ICsgICAgICAgICAqIGFuZCB3cml0ZSB0byB1c2Vy IG1lbW9yeSB3aGljaCBtYXkgcmVzdWx0IGludG8gcGFnZQo+Pj4+ICsgICAgICAgICAqIGZhdWx0 cwo+Pj4+ICsgICAgICAgICAqLwo+Pj4+ICsgICAgICAgIHJldCA9IHNsb3dfdXNlcl9hY2Nlc3Mo ZGV2X3ByaXYtPmd0dC5tYXBwYWJsZSwgcGFnZV9iYXNlLAo+Pj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIHBhZ2Vfb2Zmc2V0LCB1c2VyX2RhdGEsCj4+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICAgcGFnZV9sZW5ndGgsIGZhbHNlKTsKPj4+PiArCj4+Pj4gKyAgICAgICAgaWYgKHJldCkgewo+ Pj4+ICsgICAgICAgICAgICByZXQgPSAtRUZBVUxUOwo+Pj4+ICsgICAgICAgICAgICBicmVhazsK Pj4+PiArICAgICAgICB9Cj4+Pj4gKwo+Pj4+ICsgICAgICAgIHJlbWFpbiAtPSBwYWdlX2xlbmd0 aDsKPj4+PiArICAgICAgICB1c2VyX2RhdGEgKz0gcGFnZV9sZW5ndGg7Cj4+Pj4gKyAgICAgICAg cGFnZV9iYXNlICs9IHBhZ2VfbGVuZ3RoOwo+Pj4+ICsgICAgICAgIHBhZ2Vfb2Zmc2V0ID0gMDsK Pj4+PiArICAgIH0KPj4+PiArCj4+Pj4gKyAgICBtdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRl eCk7Cj4+Pj4gKwo+Pj4+ICtvdXRfdW5waW46Cj4+Pj4gKyAgICBpOTE1X2dlbV9vYmplY3RfZ2d0 dF91bnBpbihvYmopOwo+Pj4+ICtvdXQ6Cj4+Pj4gKyAgICByZXR1cm4gcmV0Owo+Pj4+ICt9Cj4+ Pj4gKwo+Pj4+ICAgIHN0YXRpYyBpbnQKPj4+PiAgICBpOTE1X2dlbV9zaG1lbV9wcmVhZChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+Pj4+ICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVf Z2VtX29iamVjdCAqb2JqLAo+Pj4+IEBAIC03MzcsMTcgKzgzMCwxNCBAQCBpOTE1X2dlbV9wcmVh ZF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+Pj4+IHZvaWQgKmRhdGEsCj4+Pj4gICAg ICAgICAgICBnb3RvIG91dDsKPj4+PiAgICAgICAgfQo+Pj4+Cj4+Pj4gLSAgICAvKiBwcmltZSBv YmplY3RzIGhhdmUgbm8gYmFja2luZyBmaWxwIHRvIEdFTSBwcmVhZC9wd3JpdGUKPj4+PiAtICAg ICAqIHBhZ2VzIGZyb20uCj4+Pj4gLSAgICAgKi8KPj4+PiAtICAgIGlmICghb2JqLT5iYXNlLmZp bHApIHsKPj4+PiAtICAgICAgICByZXQgPSAtRUlOVkFMOwo+Pj4+IC0gICAgICAgIGdvdG8gb3V0 Owo+Pj4+IC0gICAgfQo+Pj4+IC0KPj4+PiAgICAgICAgdHJhY2VfaTkxNV9nZW1fb2JqZWN0X3By ZWFkKG9iaiwgYXJncy0+b2Zmc2V0LCBhcmdzLT5zaXplKTsKPj4+Pgo+Pj4+IC0gICAgcmV0ID0g aTkxNV9nZW1fc2htZW1fcHJlYWQoZGV2LCBvYmosIGFyZ3MsIGZpbGUpOwo+Pj4+ICsgICAgLyog cHJlYWQgZm9yIG5vbiBzaG1lbSBiYWNrZWQgb2JqZWN0cyAqLwo+Pj4+ICsgICAgaWYgKCFvYmot PmJhc2UuZmlscCAmJiBvYmotPnRpbGluZ19tb2RlID09IEk5MTVfVElMSU5HX05PTkUpCj4+Pj4g KyAgICAgICAgcmV0ID0gaTkxNV9nZW1fZ3R0X2NvcHkoZGV2LCBvYmosIGFyZ3MtPnNpemUsCj4+ Pj4gKyAgICAgICAgICAgICAgICAgICAgYXJncy0+b2Zmc2V0LCBhcmdzLT5kYXRhX3B0cik7Cj4+ Pj4gKyAgICBlbHNlCj4+Pj4gKyAgICAgICAgcmV0ID0gaTkxNV9nZW1fc2htZW1fcHJlYWQoZGV2 LCBvYmosIGFyZ3MsIGZpbGUpOwo+Pj4KPj4+IEhtLCBpdCB3aWxsIGVuZCB1cCBjYWxsaW5nIGk5 MTVfZ2VtX3NobWVtX3ByZWFkIGZvciBub24tc2htZW0gYmFja2VkCj4+PiBvYmplY3RzIGlmIHRp bGluZyBpcyBzZXQuIFNvdW5kcyB3cm9uZyB0byBtZSB1bmxlc3MgSSBhbSBtaXNzaW5nIHNvbWV0 aGluZz8KPj4KPj4gV2hpY2ggR0VNIG9iamVjdHMgaGF2ZSBvYmotPmJhc2UuZmlscCBzZXQ/IElz IGl0IE9OTFkgcmVndWxhciBndHQtdHlwZQo+PiBvYmplY3RzPyBXaGF0IGFib3V0IChwaHlzLCBz dG9sZW4sIHVzZXJwdHIsIGRtYWJ1ZiwgLi4uPykgV2hpY2ggb2YgdGhlc2UKPj4gaXMgdGhlIGFs dGVybmF0ZSBwYXRoIGdvaW5nIHRvIHdvcmsgd2l0aD8KPiBPbmx5IHNobWVtIGJhY2tlZCBvYmpl Y3RzIGhhdmUgb2JqLT5iYXNlLmZpbHAgc2V0LCBmaWxwIHBvaW50aW5nIHRvIHRoZQo+IHNobWVt IGZpbGUuIEZvciBhbGwgb3RoZXIgbm9uLXNobWVtIGJhY2tlZCBvYmplY3RzIChzdG9sZW4sIHVz ZXJwdHIsCj4gZG1hYnVmKSB3ZSB1c2UgdGhlIGFsdGVybmF0ZSBwYXRoLgo+Cj4gLUFua2l0CgpC dXQgJ3BoeXMnIG9iamVjdHMgRE8gaGF2ZSAnZmlscCcgc2V0LiBXaGljaCBwYXRoIGlzIGV4cGVj dGVkIHRvIHdvcmsgCmZvciB0aGVtPwoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==