From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 08/13] IB/srpt: chain RDMA READ/WRITE requests Date: Thu, 10 Dec 2015 10:42:30 -0800 Message-ID: <5669C796.5010406@sandisk.com> References: <1449521512-22921-1-git-send-email-hch@lst.de> <1449521512-22921-9-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449521512-22921-9-git-send-email-hch@lst.de> Sender: linux-scsi-owner@vger.kernel.org To: Christoph Hellwig , linux-rdma@vger.kernel.org Cc: sagig@dev.mellanox.co.il, bart.vanassche@sandisk.com, axboe@fb.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 12/07/2015 12:51 PM, Christoph Hellwig wrote: > Remove struct rdma_iu and instead allocate the struct ib_rdma_wr array > early and fill out directly. This allows us to chain the WRs, and thus > archive both less lock contention on the HCA workqueue as well as much ^^^^^^^ Did you perhaps intend "achieve" ? > struct srpt_send_ioctx { > struct srpt_ioctx ioctx; > struct srpt_rdma_ch *ch; > - struct rdma_iu *rdma_ius; > + struct ib_rdma_wr *rdma_ius; Please rename the "rdma_ius" member into "wr" or any other name that shows that this member is now a work request array and nothing else. Otherwise this patch looks fine to me. Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755339AbbLJSmn (ORCPT ); Thu, 10 Dec 2015 13:42:43 -0500 Received: from mail-bn1bon0073.outbound.protection.outlook.com ([157.56.111.73]:21952 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbbLJSmf (ORCPT ); Thu, 10 Dec 2015 13:42:35 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f79f76d000007db2-67-5669c796819e Subject: Re: [PATCH 08/13] IB/srpt: chain RDMA READ/WRITE requests To: Christoph Hellwig , References: <1449521512-22921-1-git-send-email-hch@lst.de> <1449521512-22921-9-git-send-email-hch@lst.de> CC: , , , , From: Bart Van Assche Message-ID: <5669C796.5010406@sandisk.com> Date: Thu, 10 Dec 2015 10:42:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449521512-22921-9-git-send-email-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42JZI8azSHfa8cwwg4e79S3+7znGZrFy9VEm i8u75rBZPDvUy2LRfX0Hm8Xr40+ZHNg8ps/YxOoxsfkdu8fumw1sHp83yQWwRHHZpKTmZJal FunbJXBlLJ23galgKWvFmwfz2RsYJ7J0MXJySAiYSNzf+ZYdwhaTuHBvPVsXIxeHkMAJRomT szayQjg7GCXuLuxlg+n49vINI0RiE6NE6/EOIIeDQ1jASaJlsR1IjYiAg8SMTzPBpgoJZEs8 XdbAAlLPLNDDKHH03n5GkASbgJHEt/czwc7gFdCSWHeklRnEZhFQlVi0dhETiC0qECExcUID K0SNoMTJmU/A6jkFrCWmXmpnAtnLLGAv8WBrGUiYWUBeYvvbOcwguyQEbrJKXG2bxwpxhLrE ySXzmSYwisxCMmoWQvssJO0LGJlXMYrlZuYU56anFhga6RUn5qVkFmfrJefnbmIERw1X5g7G FZPMDzEKcDAq8fA6yGWGCbEmlhVX5h5ilOBgVhLh/b4TKMSbklhZlVqUH19UmpNafIhRmoNF SZzXukUtTEggPbEkNTs1tSC1CCbLxMEp1cAom17ZfTzqbn5Spkxswpm6dJME9js/rM8tPxvh F/wsvXnOs+/VYdb5ge3uVWbOT/wdV3aobyiLkulqSZ3ca/PAkv/iplz7zMgv2aprNOKT/b9d 2j+hlnFxZ6NBS4DZjy1vZU951t3k3/5j6vU1qycnHNRLsp750M38XtGPLUb1ze/6frO9najE UpyRaKjFXFScCAD82r3olgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42Lh2siRojvteGaYwbbP8hb/9xxjszj4s43R YuXqo0wWl3fNYbN4dqiXxaL7+g42i9fHnzI5sHtMn7GJ1WNi8zt2j903G9g8pq05z+TxeZNc AGsUl01Kak5mWWqRvl0CV8bSeRuYCpayVrx5MJ+9gXEiSxcjJ4eEgInEt5dvGCFsMYkL99az dTFycQgJbGCUaJzXyN7FyMEhLOAk0bLYDqRGRMBOYv3rJlYQW0ggW+LpsgYWkHpmgSZGiXtf d7KBJNgEjCS+vZ8JtoBXQEti3ZFWZhCbRUBVYtHaRUwgtqhAhMTECQ2sEDWCEidnPgGr5xSw lph6qR2shlnAVuLO3N3MELa8xPa3c5gnMPLPQtIyC0nZLCRlCxiZVzGK5WbmFOemZxYYGuoV J+alZBZn6yXn525iBIczZ+QOxqcTzQ8xMnFwSjUw8k+dcZGR8VLVPONX/UdishSTmkx6Ws+a G9xl7vu8WTxsjX68ymO+g0eUqhM/iB+4HfZDz96Rt/P00syXe4zlfbe+XHh01lzjemt7nn2v H9wT4Knqfc9b9DTTj0vRSXxRkf68gmOpc02aPUI15tXsFzieqfVPLknplEbIl6hHK49ftnql p79ciaU4I9FQi7moOBEAwWNoxxcCAAA= X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD048;1:DDnTnbL83KsebotC9X//+fhg+qCaM2EwRaYIpx3/pFnnuAiewXciWDpP8xRugFY1Thv3CYdsHmLeD0FN6EQnjrR8bGJzNj23wgTZdvKAaHsTcd5PC6HBTyZY7+N2n4nUZkZGB/e9wTCb/1rB8AsrNAlFhRbjoN9K4Jhc7ZIvFFuyUOMzxGlb5kVUmTBAQYl1utMEv9zOJ8zqFNbbpW+63uM5oBGes5cLnDiCT7QnQE+Lcq19KyTqqnSkBW5kf+lS6RjgP8Ounk0g80hVLNhJZF+JKYGpvU7WoQAEY6mnlYhjo9ku8FWMrPt+lW3neJRe0KscjFA7wzGl+5eRJu2Qya8Rt98XFd5r77XLpCoqHN6gAr8fIbZzslIdbu0vN5H3XiESnc3BoyrkJyzKHFMI2R6/PpXct4WI9zhtpIjEvX4= X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(199003)(479174004)(189002)(377454003)(4001350100001)(81156007)(5001960100002)(59896002)(5008740100001)(65956001)(586003)(97736004)(106466001)(1220700001)(54356999)(5001770100001)(1096002)(36756003)(50986999)(87266999)(230700001)(65806001)(47776003)(23746002)(92566002)(87936001)(11100500001)(77096005)(76176999)(65816999)(83506001)(189998001)(50466002)(80316001)(2950100001)(86362001)(64126003)(69596002)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR02MB294;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB294;2:bLz+livd72U5jvpr34BQZTSY38szbEIuqYxfg+Dy3kjN6z0DoXSs3cXL+GUby+MwoSiusn6qy7LGSQmVLoZVOwLVlF6I5yk1qDWpSSkdGqaYIuyjVKc7v1BjuvGKjKdAB5Iev6yKaWEqKy7X9UY5cg==;3:pOkz1HUSWEdlaNUQT+Fyzs59OvTN3DF8DVCVXM0pYL8HhB1O5WGTcwC9p4Xt94wThMWq7vPY3lkB8C5ucx2LpAcMLySJZH18u/j3ArlbhcJqBKqFXK7XfBY08U8++2S2Cqnk/hMgoTvSvQyh64C/gwsPsgpgOQ9ZnRMtDgTrV3Ss6YNv/0u0DMoKbrxzm9WLS7zEk7yWMS+9X/w6Gi4MJZifdz62nCSfxX1fFZ/ufaXnWTwCwigsRdkHDO9wbfWt9C1uFQOjKFVQ4OlvJNrhZg==;25:jTcdRDJkpPMdKvdH91sAOMUEUY/v8gr/hmfS9YAnhAMxo1Ebb5Rj46SgwRnSivQnG4qNZ3rPhCjeBiMpPNsmSYE1QSFdXTOwq6ze/Q6ISrIvof5OMZQ6J89SQY/GuOO6KrdEtvQckLShh/vRPM5/csAr90zE0GQAwXYCt2l96OE3HPcg70FP/XDWKXEZZJ3WuuB7hWglHR4tZu0EIqdV1se8T4IExPgKfibCj/FyKc6sBAeZeRtRbBux97Ak9xfKDCz2wjHaqm0r24n4b1rM8A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BLUPR02MB294; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB294;20:lphD38Cx/xBYQ9mprw/rNZ1G1WpvNSgSxQK5ddiTJfI9veMOFzPUzfOTjsEtKXq8SZpMGW1LB8q2/dgt0uFSOCH9JlpT3WtGI/MfF4s/QNIzhQLLUedvao02g5buTR1g7r2qw6MjAv0l79pUAMDnXAEWGHUtfgM3RLeX86cahGhzwaTVL/WJKZ/rW45M4ngehxgUQpRpF7+D+meAehRzE/z615rB1rAARrl8Axm7MkLoSWGcljEBcTad6PfFOIwCrVPn/AXGULbmhHFvh/9perr5Qk3say5qC7QZTFhw56I+GRFUgyRu98uIK9qo3SbRHySnbZbCcVlZjXHrgGhZCrNqHuvg8VYNPM+QOqc5g7KGCOW1FBkRmXYPQLa4DEAc0K+MFtQqvQRdNJogJlYeIgm3WnvhLcaQhg5EE9NCVQyCw/cyDJ4iKiOSHKg3XjUGug9QG51t1pjW9Q+AurYuwZz19VCPTQZ6wPzRHUsWa+LYqB16Q57ampV+BsK08RZk;4:1dfCrQrvA3j6MeBGBrkcpN438LhBrOGpCrh6MxadBPwUgCPAycQbHs8vxkREHNWX392j6lfrnktfAgodqQHY5M3/rdRFrFlxk2qgP+fiy9GUInVvLsMsHQWSF+k3sP+7/UEVLeY6VU8zzau7Dd5F4E7eFhUwZrXHjQ1N+PU8oHhsTgxhpDVEZ8Zq6tPXhG1vz+ZbEkcuf3dUBUi79ZmPTWvI+QLPE1+iuzBoRwGonxpg6cmjAr811UPUyVSec5ix6Q2cUi3tGUiif6bgDrFtihPriUzpU4G3mhPjYIxtvU6XiBlU8RFigPXSm1ho5GfG0d3/gjwiG+MXVx6WsQEvqtaHHOHOJHIsPnbDt01rAnoaRCxjpPZRfWzfzPwwcJfy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001);SRVR:BLUPR02MB294;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB294; X-Forefront-PRVS: 078693968A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR02MB294;23:5pkJdvguBBGiBWgaFiz6LPau35Iyp4l7B6Y1dn?= =?Windows-1252?Q?P6FPpgs8hmAiA0xl92LB51TKENMqc+gkK+tOZ0t01LbomNolQQF62tG1?= =?Windows-1252?Q?KuH6ZTXBohKsXxp2wiQfLM/sw58p7jT4UQ2xgw1kA6d62XfX/v5XTigB?= =?Windows-1252?Q?Jmb2dUeIyP+SZ498huJ8CtK4tPoL9cvx6TK7CpbdHHxQHwm/M6dbIb2T?= =?Windows-1252?Q?ZX4nRn3sdRc7Z1DMax0G0Fq4qY4TKdqo5PYA+PMNFMLCEcTky1YTOGY3?= =?Windows-1252?Q?WPHGuNCiervozV0P5zYFIYhMmgqr2gTIx/DbXA6ZlJgPC5Lp8cqUkyDV?= =?Windows-1252?Q?cHx1JC0aNH8FSXVT5klXlTGOsFm34zsfwWqMxM+QNKWV5h6aIXgQA3VT?= =?Windows-1252?Q?rEH6VvF24XgIBS4KBxf5aqfH0VTdWr46Y32FWu3Rh4G54BtZPhFWBbZB?= =?Windows-1252?Q?5QrX1q2Wjyv/pPz2d4YZ2Jz8xbCpFE3oJu7cT9qMuoko7FFbLIaPqMlw?= =?Windows-1252?Q?2WAv9O40BItMmbRs+H4x23JYKkaba4p5TM2GqjYseyYBekT81TN6Tp4x?= =?Windows-1252?Q?0UVRPKifdFRzayGcLGDaO8X2n5deN09IwifdI8EvSYUiEdEUBxFfLj/f?= =?Windows-1252?Q?ZONi+v/rEgC6k0GCTXmucxBwq+Do6ryCQdtfuHwXf3TFb2/lmyXVaA47?= =?Windows-1252?Q?aBETIL25zgsr7MDdOj8rzEoQ1Im0YElBRTPlyagfS2gnORvCpiLd537T?= =?Windows-1252?Q?1IeQLLhAxKx5TtNzkqQtNst9LBbTwPP9GbFy9zR//OTfZ4yqlDY6e+UU?= =?Windows-1252?Q?KLL6WvLA86IYSEGMbPMglUvSUZKqd5or8gz5ES2mM+DqhQEF2OMgfsR5?= =?Windows-1252?Q?HaPxVjsQSSbw5cUhq5Of0QhWh/qA6aRMmsrjtHdl2U8nl75BZ3rQ0aDS?= =?Windows-1252?Q?1myEn61sjURIT9XT0dgOZ0vo22jpFqIBoQi9dklouWA3J20OeN0oeWTV?= =?Windows-1252?Q?/WEH5XmIPA2FBY7VkJzEryCXBJ2WAe2GhqonmxlA7MogjulsIGmXaP6K?= =?Windows-1252?Q?Are5MhBkNbOWir/376aeLoDGiPZo0TyDpu5UWqhIMMyC4UQtqYLSj9cE?= =?Windows-1252?Q?A+khJxO8apZzfCvzW//GN1XC/6OZ1zkJ77jBY5fKN8E1ZvgdyhdgyxJ2?= =?Windows-1252?Q?0fYhyd8ABjcQx272e+T29UBKSgZs3INsehrj9jMj2MpUQIBCR5?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB294;5:TeIVstWj1iHu3igtrUTR7cHrgr3fH4fEBc7g6Y4IDYEEqOwlMYehTqntkSfdyi06bF39E62TOJOECaYDCf98WlZWUXUyZKQevoTYiiJRss8TafK0+oOpek8sRcnMBgKZxr6d+tKZzKZ5BiSL8v1bvA==;24:V1RpPTsS5QTx//rvwzKQ42vWejswWCHfMOpL3eZOtuO+e+9Pq9rEZ1i8eWGR2giY7m3vT61XL02tOvZXkob2uoMyV9pN0vEF42UO9cDWD8k=;20:4pl1+QsrEmUtnTKxzxF77I+oHC8cZjj+HXrtK94aHN9iIOMPRphiO3VDM5ziiFwQTVXsbafcgT7qCWoO6SRfxGl/YmrURwdAQZjRGmfoYztZFN2biaqs/L8hXOPebf/hzt7ALnOkb4BgJcVm/MKlBUhgxejdpojpt4ZFSE8rinQTwSOYbawEKsxTpevAlnlE9sSlz9HI62a7dFGknTm03I6ILBJ2NqmSVvi1fs2W6DYKQgtNT75KRoxJRedncwd1 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2015 18:42:31.2822 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB294 X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB129;2:nwS/WJrr+MhzclpDXhD95pOG8Hf0ajXCOqOyP3OlUa6U9j9qrLQoIbnDwrADECJsGxSKNLLChE53UFnxEaSaaW1oBhnHxio27+0wAc1bq0Lz8sGq9YVUIqVJ0bqpr1V4VHRuZir/A0JcjINnzLp1Jg==;23:e90X1yt2kXqwNnEqh3NLwbXe3Q08jgARYG1IZ6Axx0Jwff6MOHq4Yvupa+misjdw7cNd/ebXYmY1OnKwY0ugm0UViaBSqAL+rn8A3J1yYSCkC1uZqalAisd7QPpw1baD0u/6/ELuArizExznt6KCDjZgjW6HrJcHcAP2gafX4tsgGXoyWOHK0CH1+tqsap0m X-OriginatorOrg: sandisk.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2015 12:51 PM, Christoph Hellwig wrote: > Remove struct rdma_iu and instead allocate the struct ib_rdma_wr array > early and fill out directly. This allows us to chain the WRs, and thus > archive both less lock contention on the HCA workqueue as well as much ^^^^^^^ Did you perhaps intend "achieve" ? > struct srpt_send_ioctx { > struct srpt_ioctx ioctx; > struct srpt_rdma_ch *ch; > - struct rdma_iu *rdma_ius; > + struct ib_rdma_wr *rdma_ius; Please rename the "rdma_ius" member into "wr" or any other name that shows that this member is now a work request array and nothing else. Otherwise this patch looks fine to me. Bart.