From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 10/13] IB/srp: use the new CQ API Date: Thu, 10 Dec 2015 10:42:50 -0800 Message-ID: <5669C7AA.4080206@sandisk.com> References: <1449521512-22921-1-git-send-email-hch@lst.de> <1449521512-22921-11-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449521512-22921-11-git-send-email-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , linux-rdma@vger.kernel.org Cc: sagig@dev.mellanox.co.il, bart.vanassche@sandisk.com, axboe@fb.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 12/07/2015 12:51 PM, Christoph Hellwig wrote: > +static void srp_send_done(struct ib_cq *cq, struct ib_wc *wc) > +{ > + struct srp_iu *iu = container_of(wc->wr_cqe, struct srp_iu, cqe); > + struct srp_rdma_ch *ch = cq->cq_context; > + > + if (likely(wc->status != IB_WC_SUCCESS)) { > + srp_handle_qp_err(cq, wc, "SEND"); > + return; > + } > + > + list_add(&iu->list, &ch->free_tx); > +} Please change likely() in the above code into unlikely(). Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755380AbbLJSnA (ORCPT ); Thu, 10 Dec 2015 13:43:00 -0500 Received: from mail-by2on0077.outbound.protection.outlook.com ([207.46.100.77]:27328 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751383AbbLJSmz (ORCPT ); Thu, 10 Dec 2015 13:42:55 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f79f76d000007db2-70-5669c7aa2e7c Subject: Re: [PATCH 10/13] IB/srp: use the new CQ API To: Christoph Hellwig , References: <1449521512-22921-1-git-send-email-hch@lst.de> <1449521512-22921-11-git-send-email-hch@lst.de> CC: , , , , From: Bart Van Assche Message-ID: <5669C7AA.4080206@sandisk.com> Date: Thu, 10 Dec 2015 10:42:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449521512-22921-11-git-send-email-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42JZI8azSHfV8cwwg+6txhb/9xxjs1i5+iiT xeVdc9gsnh3qZbHovr6DzeL18adMDmwe02dsYvWY2PyO3WP3zQY2j8+b5AJYorhsUlJzMstS i/TtErgyzk5pZyp4xlzxZZVPA2MLcxcjJ4eEgInE5lW9bBC2mMSFe+vBbCGBE4wSU5rMuhi5 gOwdjBJPpz1n6WLkAGv4cTQMIr6JUWL10g1gg4QFTCUObv7HCGKLCDhIzPg0kx1iUI7EzMed TCANzAI9jBJH7+0HK2ITMJL49n4mC4jNK6Al0bmzBSzOIqAq8f7HdTBbVCBCYuKEBlaIGkGJ kzOfgNVzCthIfLr9ghnkIGYBe4kHW8tAwswC8hLb386Beuwqq8SsVxYQN6hLnFwyn2kCo8gs JJNmIXTPQtK9gJF5FaNYbmZOcW56aoGhkV5xYl5KZnG2XnJ+7iZGcLxwZe5gXDHJ/BCjAAej Eg+vg1xmmBBrYllxZe4hRgkOZiUR3u87gUK8KYmVValF+fFFpTmpxYcYpTlYlMR5rVvUwoQE 0hNLUrNTUwtSi2CyTBycUg2M+ZH7XcJVLnLd+Mjs07r4rsWhn0q35aucvRV99dwfTjYyVhJa +mRTbWfFF48pJ25sVkt0k0uavp/ZeNY8qfw3twLtVd2m3Z8xe6evqtxmm2UXKvatNyvvZ372 8PWqOolY7bct2hsyst6/U8xYdi3747l5Twx5xfYlb3/FZvjdaL5d9IoDGbZPlViKMxINtZiL ihMBXGIO/5MCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmluLIzCtJLcpLzFFi42Lh2siRorvqeGaYwdIl6hb/9xxjszj4s43R YuXqo0wWl3fNYbN4dqiXxaL7+g42i9fHnzI5sHtMn7GJ1WNi8zt2j903G9g8pq05z+TxeZNc AGsUl01Kak5mWWqRvl0CV8bZKe1MBc+YK76s8mlgbGHuYuTgkBAwkfhxNKyLkRPIFJO4cG89 WxcjF4eQwAZGiaXPljGCJIQFTCUObv4HZosI2Emsf93ECmILCeRIzHzcyQTSwCzQxChx7+tO NpAEm4CRxLf3M1lAbF4BLYnOnS1gzSwCqhLvf1wHs0UFIiQmTmhghagRlDg58wlYPaeAjcSn 2y+YQWxmAVuJO3N3Q9nyEtvfzmGewMg/C0nLLCRls5CULWBkXsUolpuZU5ybnllgaKhXnJiX klmcrZecn7uJERzMnJE7GJ9OND/EyMTBKdXAuM/NcU7Zn263hxMvzcqqVDyntzmhW7O78eG5 EgaDyR91fLXKMprt9/FVGMjpm6oyLxdrKegX6OFvdn3DsEVOpiLdZ8O9O/Y83W0aq40L4/Nf 8d6Yl7Jgocy/2dzPUx3TW1umn26da/zn4Pz7Lx95Tr++Zm5J/0Pu3+tE2NXUsljq3lWXJ0or sRRnJBpqMRcVJwIAOSk8dBYCAAA= X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD048;1:rqv0Zp0YHWkGsDC9sS17LUe6qZKPy9vPyqKGferg6Tty8OrR7r0QB2+Aa++F6kV1iobiqx1CHVbTAHaxLXxKbhrZQHGqWxSZFoPwy+EQxn8zVOd5OHMllFdAI9NOB3Jro2r0NvSCrxZlQOBEFVjZh5T7TD1WBN9a+2ozMYHLE9dXa+50SEPNF47POjGI9tZ09ly2E3hKYU9JJOGqFmJ8Z/qIpYojFRpopNFHuvpuyGHXfeIN0b3q5inFHR0Lxr4sEkadWzaiL0CDNYy4adhzH/8uk83livFemYa603HZPt44A0rpu+BtZey+oqleRPXfxEh1kVv1oWXoaJOEwMnXz5xyNxLIDcjHXY3UivAV4H3Xg3qL9JKL/aePM99hyRkd X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(479174004)(377454003)(189002)(164054003)(24454002)(5001770100001)(23746002)(4001350100001)(83506001)(50466002)(97736004)(81156007)(64126003)(5008740100001)(92566002)(80316001)(33656002)(1220700001)(86362001)(50986999)(87266999)(1096002)(65816999)(76176999)(230700001)(54356999)(69596002)(36756003)(586003)(2950100001)(106466001)(59896002)(189998001)(65956001)(65806001)(47776003)(87936001)(77096005)(5001960100002)(11100500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0201MB1571;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1571;2:X1ih2g2ssXE7HoNIRDjHrxiNjWiXmkUJQtecz/JfdXJsSTXjgJCi8//cx7E0wCO3MDgv9M+IpdWAuLd61iXmhd4VeT0E17utAlN5ZAtU8qK9yaKF7R0QdZ6AIa0t+qlCpaXADoWqI8aY86Fcr02Fiw==;3:0yl5Vlg9MalecqEHALNTseKR6gV2ioO39tQrv9TS9HRveZEzsUaRVeutgDRchovvL9fOP+aCS7b3MFNBgnL6MhWvUWR/QEfwbRjq97NPTlMxh1+nlclpwQrlRh3LJXpTMgs2AXgN1eKzCakvHKWUW3afsfB6zPh1a2R+TToUUgfhohp8d8TIhkvlmlHVvAE/25AdzklH2uxIwDZNji/JxvwTi7Lt1Qf6fXVBBEKBVoOhbfbYboLrjc9a3kFw1CfnT0qEu/vjmMSszc/eU8HSQQ==;25:M/zF4iWaH7F3aqMM4alJtcZNgg7YMGR0b4SD9ttmSMdUeDsmoUQUe4XcjCIi68rzluZaLf87vOw/Qg2wChOWYtXmMxZEoz3jj6rHe10K9zk2QBVjc7uaLp08zURA3HNKIaHsXUsqmUW0QzGcjU/glbDrf3gIHa/W/Uk/eC5js4AvvgC4Zzyhrhpl7bAKyAmrKS27FznucmGmtLiQE5fWr9i4xhfN+znoCiq/mE2CKwWannpIbtra4tTWmnZPmOqj X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BLUPR0201MB1571; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1571;20:sfl0BbtY29OO2FFeKiYsxu0+H7t7Yyc7cJCKJNeKLqVb+ZkPRW2qpkDfbRZdcuR9MonleAVMCMUM3QDdUjvz915XZTzFij0pEx8F3p5legKQrvN2cMH3TIreuzNCvzBQTzmIf2kVAEXjweHIY1vrorcbeEY6mU2M5Qc4rNlO8B2hm5XmCwerpUDGHuvW6KK6TVLq7fFOtQwCAzKOgvMBpvApPOdaMBh8jcykDShPd9cXer9BEamFq+HCAanPO+crXvxtNerLT47ON2B4+KBT/UxQVsAhQ/EHi6kDj0WaTV589db1E7Blqcu58REAbUU6dknIUZrIIIQ3taRA4DltJ05erkUqIiptQCoM+Xymh+EtSCENQwzOT+mzMLHZztdN20h/2RdGc22SRyraPR9AGyDiUKG1ja5JIz73lmG/7oWQGOEheAPpmxe/BYlBqbVzMrkNRw5a7JLadKGcuW/HLh600qeitV9wacJ4WVsUk5E6fax0SCsHU1jV032HqCMQ;4:VAKZDhIN3U3js0dD3QHqQh1Zs7KedRzMwroVBcleH+EO0LayEu9TDJ1Rm2pLAfzwMqq4mgrmX/Vn5TQG29TMjEZd9D/EjJqwsPNGr75LKeYPizEckotbKYCD0ErXYOOuDbWBm0DXBca83tDTWUEDw/jWTRl2XMyhedCKgd4pEpayy+RQgKvWkDg/mCVJRHb2rjWxuDcsBQNygQA3uT7pxpOdDekPVxSISL4DGu0mJ9inwRf9pDCDUorB7zIWPQaCQDfbNYM7Ts7jYZwaOelwDMrnZdP5Qz+RkreZLasrkARUoU7WTsp+UoIrJfZQhACiZVb6L6vOhvP6FibyXHLDIAidOuAT2R5slz8k8hKfx32p+OoFkHkISwzOPxFQRGBf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001);SRVR:BLUPR0201MB1571;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0201MB1571; X-Forefront-PRVS: 078693968A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR0201MB1571;23:mPRzG0xZpq+0neY/PeQIRhm6dGjFjjkbvBD?= =?Windows-1252?Q?I3VlF0bzRXzKHWO49YiT1+mSVB91yI106Dy275FvKUSYrip3aGJSRAxZ?= =?Windows-1252?Q?CfqzlYb6yDemhcgvQ03I16Vi1NHHdN4Ep+Oo9r78dlM1YLv6GYlzSzMj?= =?Windows-1252?Q?oLnd+c0XevZ/FvDuQDiXb8r6F8Syeryus95USGEHuAK+irAaVFynmZlC?= =?Windows-1252?Q?c2SG3NyTOEVywMAYorAQcEkvNgwal2Qou+r6fujj+cgKVNnHMT+oU91H?= =?Windows-1252?Q?3sq4RvWEIOsca1/H7ontOWOgakDXX7DbQ2c/12PQMpSGpmEEXvkgd1lv?= =?Windows-1252?Q?wNtMZFE80FQcUseOn79+VZqFRAPUoGbQ41hMx3zwIRDHdoaVIhbFfngB?= =?Windows-1252?Q?b4oIP3eZnPQbhGFA09To7y2Mu/zLL/LYaalCGIsB2lTHwkR/ZCXTaYsN?= =?Windows-1252?Q?Moavhj7GjqoidL7XX4zybPWAav9yc/xAblqTQvCdJ+afYPJMO3vaVEVR?= =?Windows-1252?Q?Bo7zw1r0yLKwZMuHZ5rv8bM5W7lcBaWIE+F2wC6QjaFeljrWRrRLHMEZ?= =?Windows-1252?Q?mZuQvaxR6258p0UjluYNy3/RaI0Y50I+b/2sOmHXDYiT/t056XbDK6zH?= =?Windows-1252?Q?yy8OCEN4Z5KsOd3ePpavUIPjPv/F8NecxuarGXqxKId3N24KTh72FQhH?= =?Windows-1252?Q?SJx8pUN+O0h7Y6py9dUziwL/5gIwd+Q97FJ+AwUe4z+R+7uwoflNGl0m?= =?Windows-1252?Q?35ovuwmZReO9tmhV80G8FRH6e8GgSg+XEeIe2H4IcZJ5qyuTbzqqA7mq?= =?Windows-1252?Q?XRt+ooBZwQMLfdtgk7zU5jyeOHtgOs71ar36+Tb8KS6cYBsozZWJbGr6?= =?Windows-1252?Q?aSmgtNju+4KmwlYTivmrPaze39ncp0+BFkbSjtjg095RgIHvzTS/gKwg?= =?Windows-1252?Q?zUkMx742wirlWVV5k4DwLZKxBfjrY2KfQbPGbC6jkqfWKpRuhU4ksQFY?= =?Windows-1252?Q?wT4kAJBYnX7WqIW61VJsZKFaMlaCtUGL8H/OJ4PnSyiZ+SRYIa8X/rAQ?= =?Windows-1252?Q?iIYlENb+dhiLlI9Nc61dXT1902CN9KBa5h9XaSYa/5JK+HhCuKBKAQEG?= =?Windows-1252?Q?Ed3uJkFP9KjHz3PNZGtxWHOFN00bgYP4d/suoTs+cgQmsp9DFLAQrgtF?= =?Windows-1252?Q?8dWGYpDD65gU1mmIreZhg7EGPd0pd1rdkdwE5d4poRTvnU3OnwHe4qqW?= =?Windows-1252?Q?C7M5mqwoeYoQX0134LQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1571;5:sVJn/CUQw5lV7XIIKHXkYn7WnARJJ8spT4xM8RvpE3aghEFoPI+0h8dNE4ucJXgeeJ+ZAPXYfbCTxAcO/4hk0i2ngXyemS3DMZ6IbD+rYcf0i9/hbB081nkO/HYkv/LAL+bzv8QZmHuy7p0j5pj8DA==;24:oey/gmF01uSqJquQuIny8lWbiRwFK+CNDWBCAY27W3juu1ZP+cJrbPHEqcU1l6H8wI5C/9iu/vlrRAlz8qJ9zGB9ShtCd07fWPSUnkTsQ/U=;20:nUhECKGJ3tZ/KGyugIi8YMWSEWISX8SkriJ0AsRYHjKMStOwHuSxw3wek0YdtNXnm0TGEBR4TZ2fHWvIiiZnTZRqz0NE7k6XTxO4MHOAooaSTwdKs+l7iYNLKE4lYEb61n0ChC9ElIIfsiHE9Xdf4BI3HI342qO0I3vn2lxsqsceI6SC1hp9Soh1bG4TEvOCq/p+gaM7Um2tEUFjqYl2UWzSjD+84CrhNn0+55j90PITjHJEJBkCcD2B+cwai0oB SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2015 18:42:51.1408 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1571 X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1508;2:UycK/FHPPGKPaErJyHtmdeO/PAf6U7O7R/aAnO5f3OtVIf9tsJYxJmPr/sOOTVi6EuHLsvwyyL3am+qqH22uAXC1qXm1d9L9RiBmAF3t4+qjsAjLNe/fAud1Q7BC1hbN/ZYPy5HAuJxprb7yOVNd2A==;23:zH54OI214MQmhdRtvRqsjak8NLgrO7mCgSVQbsK0ZtCs4KK1CBITxHOKc+GVxvObOTMv1aEc5d/dmqpKAgogYV9XmjD6R2wQ8FEqaxfiX3HUp3GSeQAxKrrZJjYLRYdIQUOmi/qBiVTkQtUeS/uBtmV4owWUbODxFKwAUwNmk/5LGjx6oIAfgMabKO2j3jxv X-OriginatorOrg: sandisk.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2015 12:51 PM, Christoph Hellwig wrote: > +static void srp_send_done(struct ib_cq *cq, struct ib_wc *wc) > +{ > + struct srp_iu *iu = container_of(wc->wr_cqe, struct srp_iu, cqe); > + struct srp_rdma_ch *ch = cq->cq_context; > + > + if (likely(wc->status != IB_WC_SUCCESS)) { > + srp_handle_qp_err(cq, wc, "SEND"); > + return; > + } > + > + list_add(&iu->list, &ch->free_tx); > +} Please change likely() in the above code into unlikely(). Thanks, Bart.