From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] public/sysctl: Clarifications to
 XEN_SYSCTL_PHYSCAP_hvm_directio
Date: Thu, 10 Dec 2015 20:07:29 +0000
Message-ID: <5669DB81.9030903@citrix.com>
References: <5658230D02000078000B98E2@prv-mh.provo.novell.com>
	<1448969850-32275-1-git-send-email-andrew.cooper3@citrix.com>
	<565DB02B02000078000BACFA@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <565DB02B02000078000BACFA@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 01/12/15 13:35, Jan Beulich wrote:
>>>> On 01.12.15 at 12:37, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/include/public/sysctl.h
>> +++ b/xen/include/public/sysctl.h
>> @@ -89,7 +89,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_sysctl_tbuf_op_t);
>>   /* (x86) The platform supports HVM guests. */
>>  #define _XEN_SYSCTL_PHYSCAP_hvm          0
>>  #define XEN_SYSCTL_PHYSCAP_hvm           (1u<<_XEN_SYSCTL_PHYSCAP_hvm)
>> - /* (x86) The platform supports HVM-guest direct access to I/O devices. */
>> + /*
>> +  * (x86) The platform supports guest direct access to I/O devices.
>> +  *
>> +  * Note that this parameter has been misnamed since its introduction, and is
>> +  * now too baked into APIs and ABIs to change.  Despite the "hvm" in its
> What do you mean with "too baked into ..."? This is sysctl, which can
> be changed, and I found just two uses (one in the hypervisor, the
> other in libxl), so changing the use sites wouldn't seem all that
> problematic (in the worst case we could also keep to current name
> behind a __XEN_INTERFACE_VERSION__ conditional).

It is libxl which is the problem.  Given its stable API,
libxl_physinfo.cap_hvm_directio can't be changed.

~Andrew