From: Simon Arlott <simon@fire.lp0.eu>
To: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Cc: Kamal Dasu <kdasu.kdev@gmail.com>, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] mtd: brcmnand: defer to devm_ioremap_resource() for error checking
Date: Thu, 10 Dec 2015 21:05:36 +0000 [thread overview]
Message-ID: <5669E920.9010706@simon.arlott.org.uk> (raw)
In-Reply-To: <1449714797-27492-1-git-send-email-computersforpeace@gmail.com>
On 10/12/15 02:33, Brian Norris wrote:
> devm_ioremap_resource() does error checking on the 'res' argument, so
> drop the error check in bcm6368_nand.c.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Simon Arlott <simon@fire.lp0.eu>
Tested-by: Simon Arlott <simon@fire.lp0.eu>
> ---
> Compile tested only
>
> drivers/mtd/nand/brcmnand/bcm6368_nand.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/brcmnand/bcm6368_nand.c b/drivers/mtd/nand/brcmnand/bcm6368_nand.c
> index 7f5359be24f2..34c91b0e1e69 100644
> --- a/drivers/mtd/nand/brcmnand/bcm6368_nand.c
> +++ b/drivers/mtd/nand/brcmnand/bcm6368_nand.c
> @@ -105,9 +105,6 @@ static int bcm6368_nand_probe(struct platform_device *pdev)
>
> res = platform_get_resource_byname(pdev,
> IORESOURCE_MEM, "nand-int-base");
> - if (!res)
> - return -EINVAL;
> -
> priv->base = devm_ioremap_resource(dev, res);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
--
Simon Arlott
next prev parent reply other threads:[~2015-12-10 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:33 [PATCH] mtd: brcmnand: defer to devm_ioremap_resource() for error checking Brian Norris
2015-12-10 21:05 ` Simon Arlott [this message]
2015-12-10 21:09 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5669E920.9010706@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.