From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v2 16/19] ARM: dts: Add PPMU node for exynos4412-odroidu3 Date: Fri, 11 Dec 2015 11:27:46 +0900 Message-ID: <566A34A2.7040001@samsung.com> References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-17-git-send-email-cw00.choi@samsung.com> <56691F54.7040704@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <56691F54.7040704@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-pm@vger.kernel.org On 2015=EB=85=84 12=EC=9B=94 10=EC=9D=BC 15:44, Krzysztof Kozlowski wro= te: > On 09.12.2015 13:08, Chanwoo Choi wrote: >> This patch add dt node for PPMU_{DMC0|DMC1|LEFTBUS|RIGHTBUS} for >> exynos4412-odroidu3 board. Each PPMU dt node includes one event of >> 'PPMU Count3'. >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 40 ++++++++++++++= +++++++++++ >> 1 file changed, 40 insertions(+) >> >=20 > The patch itself is good but now I see that it is duplicated with > Rinato, Monk and Trats2. Probably for all other Exynos4 and > one-cluster-Exynos5 boards this would be exactly the same as well. >=20 > How about making a DTSI file with common PPMU events configuration? OK. I'll make the exynos4412-ppmu-common.dtsi. The Exynos4 series used the PPMU firstly. That is why deciding the file= name of exynos4412-ppmu-common.dtsi. Best Regards, Chanwoo Choi