All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_dh_alua: fix build warning
Date: Fri, 11 Dec 2015 09:37:27 +0100	[thread overview]
Message-ID: <566A8B47.8090805@suse.de> (raw)
In-Reply-To: <1449822963-9054-1-git-send-email-sudipm.mukherjee@gmail.com>

On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
> We were getting build warning about unused variables "vpd_pg83" and "d"
>
> Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> build warning with next-20151211 and build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
> ---
>
>   drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index f100cbb..5a328bf 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
>    */
>   static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
>   {
> -	unsigned char *d;
> -	unsigned char __rcu *vpd_pg83;
>   	int rel_port = -1, group_id;
>
>   	group_id = scsi_vpd_tpg_id(sdev, &rel_port);
>
A fix for this is already queued in Martin Petersens tree.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

      reply	other threads:[~2015-12-11  8:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  8:36 [PATCH] scsi_dh_alua: fix build warning Sudip Mukherjee
2015-12-11  8:37 ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566A8B47.8090805@suse.de \
    --to=hare@suse.de \
    --cc=JBottomley@odin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.