From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 2/2] VT-d: Fix vt-d flush timeout issue.
Date: Fri, 11 Dec 2015 08:38:20 +0000
Message-ID: <566A8B7C.5020008@citrix.com>
References: <1449739990-66155-1-git-send-email-quan.xu@intel.com>
	<1449739990-66155-3-git-send-email-quan.xu@intel.com>
	<5669CCED.6000609@citrix.com>
	<945CA011AD5F084CBEA3E851C0AB28894AE59114@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894AE59114@SHSMSX103.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Xu, Quan" <quan.xu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, "Wu, Feng" <feng.wu@intel.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>, "Dong, Eddie" <eddie.dong@intel.com>, "tim@xen.org" <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "Nakajima,
	Jun" <jun.nakajima@intel.com>, "keir@xen.org" <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/12/2015 05:37, Xu, Quan wrote:
> On 11.12.2015 at 3:05pm, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> On 10/12/15 09:33, Quan Xu wrote:
>>> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index
>>> a5aef55..0bf6b1a 100644
>>> --- a/xen/include/xen/pci.h
>>> +++ b/xen/include/xen/pci.h
>>> @@ -41,6 +41,7 @@
>>>  struct pci_dev_info {
>>>      bool_t is_extfn;
>>>      bool_t is_virtfn;
>>> +    bool_t is_unassignable;
>>>      struct {
>>>          u8 bus;
>>>          u8 devfn;
>>> @@ -88,6 +89,12 @@ struct pci_dev {
>>>  #define for_each_pdev(domain, pdev) \
>>>      list_for_each_entry(pdev, &(domain->arch.pdev_list), domain_list)
>>>
>>> +#define PDEV_UNASSIGNABLE 1
>>> +#define mark_pdev_unassignable(pdev) \
>>> +    pdev->info.is_unassignable = PDEV_UNASSIGNABLE
>>> +
>>> +#define IS_PDEV_UNASSIGNABLE(pdev) pdev->info.is_unassignable
>> Static inlines please.
>>
>> These macros lack any hygene whatsoever, but don't need to be macros in the
>> first place.
>>
> Andrew,
>
> Could I modify it as below:
>
> +static inline void mark_pdev_unassignable(struct pci_dev *pdev)
> +{
> +    pdev->info.is_unassignable = 1;
> +}
> +
> +static inline bool_t is_pdev_unassignable(struct pci_dev *pdev)

const struct pci_dev *pdev

> +{
> +    return pdev->info.is_unassignable;
> +}
>
> Correct me If I still don't get the point. Thanks.

but otherwise, yes.

~Andrew