From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>, peter.senna@gmail.com
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: serial: remove redundant condition
Date: Fri, 11 Dec 2015 15:30:48 +0300 [thread overview]
Message-ID: <566AC1F8.6010802@cogentembedded.com> (raw)
In-Reply-To: <1449827205-3967-2-git-send-email-geyslan@gmail.com>
Hello.
On 12/11/2015 12:46 PM, Geyslan G. Bem wrote:
It's a bad idea to send 2 different patches with the same subject. I'd use
"mos7840: " as a prefix in this case.
> This patch removes redundant condition.
>
> (length && length > 5) can be reduced to a single evaluation.
>
> Tested by compilation only.
> Caught by cppcheck.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-12-11 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 9:46 [PATCH 1/2] usb: serial: remove redundant conditions Geyslan G. Bem
2015-12-11 9:46 ` [PATCH 2/2] usb: serial: remove redundant condition Geyslan G. Bem
2015-12-11 12:30 ` Sergei Shtylyov [this message]
2015-12-11 12:39 ` Geyslan G. Bem
2015-12-11 10:13 ` [PATCH 1/2] usb: serial: remove redundant conditions Johan Hovold
2015-12-11 10:25 ` Geyslan G. Bem
2015-12-11 10:30 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566AC1F8.6010802@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.