From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 11 Dec 2015 17:09:43 +0100 (CET) Received: from exsmtp01.microchip.com ([198.175.253.37]:46927 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27007521AbbLKQJlHXJuZ (ORCPT ); Fri, 11 Dec 2015 17:09:41 +0100 Received: from [10.14.4.125] (10.10.76.4) by CHN-SV-EXCH01.mchp-main.com (10.10.76.37) with Microsoft SMTP Server id 14.3.181.6; Fri, 11 Dec 2015 09:09:32 -0700 Subject: Re: [PATCH 09/14] DEVICETREE: Add bindings for PIC32 usart driver To: Rob Herring References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-10-git-send-email-joshua.henderson@microchip.com> <20151122215622.GA32221@rob-hp-laptop> CC: , , Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , From: Joshua Henderson Message-ID: <566AF6DE.9030803@microchip.com> Date: Fri, 11 Dec 2015 09:16:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151122215622.GA32221@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 50547 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: joshua.henderson@microchip.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Rob, On 11/22/2015 02:56 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:21PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the USART peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../bindings/serial/microchip,pic32-usart.txt | 29 ++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> >> diff --git a/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> new file mode 100644 >> index 0000000..c87321c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> @@ -0,0 +1,29 @@ >> +* Microchip Universal Synchronous Asynchronous Receiver/Transmitter (USART) >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-usart" > > Again, should be more specific. > Ack. In addition, will replace all instances of USART with UART. >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for TX/RX/RTS/CTS >> + >> +Optional properties: >> +- microchip,uart-has-rtscts : Indicate the uart has hardware flow control >> +- rts-gpios: RTS pin for USP-based UART if microchip,uart-has-rtscts >> +- cts-gpios: CTS pin for USP-based UART if microchip,uart-has-rtscts > > This appears to just be copied for Sirf UART. > > Doesn't *-gpios being present imply having h/w > flow-control (i.e. microchip,uart-has-rtscts)? > > Rob Agreed. microchip,uart-has-rtscts will be dropped and it turns out we don't really need the rtc-gpios property. Josh > >> + >> +Example: >> + usart0: serial@1f822000 { >> + compatible = "microchip,pic32-usart"; >> + reg = <0x1f822000 0x50>; >> + interrupts = , >> + , >> + ; >> + pinctrl-names = "default"; >> + pinctrl-0 = < >> + &pinctrl_uart1 >> + &pinctrl_uart1_cts >> + &pinctrl_uart1_rts>; >> + microchip,uart-has-rtscts; >> + cts-gpios = <&pioB 15 0>; >> + rts-gpios = <&pioD 1 0>; >> + }; >> -- >> 1.7.9.5 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from exsmtp01.microchip.com ([198.175.253.37]:46927 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27007521AbbLKQJlHXJuZ (ORCPT ); Fri, 11 Dec 2015 17:09:41 +0100 Subject: Re: [PATCH 09/14] DEVICETREE: Add bindings for PIC32 usart driver References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-10-git-send-email-joshua.henderson@microchip.com> <20151122215622.GA32221@rob-hp-laptop> From: Joshua Henderson Message-ID: <566AF6DE.9030803@microchip.com> Date: Fri, 11 Dec 2015 09:16:30 -0700 MIME-Version: 1.0 In-Reply-To: <20151122215622.GA32221@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Rob Herring Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org Message-ID: <20151211161630.FzmkW8fG4U3wmJ15uL8Q4LW1YNKrTb5cBIPjjjJa-3o@z> Rob, On 11/22/2015 02:56 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:21PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the USART peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../bindings/serial/microchip,pic32-usart.txt | 29 ++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> >> diff --git a/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> new file mode 100644 >> index 0000000..c87321c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> @@ -0,0 +1,29 @@ >> +* Microchip Universal Synchronous Asynchronous Receiver/Transmitter (USART) >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-usart" > > Again, should be more specific. > Ack. In addition, will replace all instances of USART with UART. >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for TX/RX/RTS/CTS >> + >> +Optional properties: >> +- microchip,uart-has-rtscts : Indicate the uart has hardware flow control >> +- rts-gpios: RTS pin for USP-based UART if microchip,uart-has-rtscts >> +- cts-gpios: CTS pin for USP-based UART if microchip,uart-has-rtscts > > This appears to just be copied for Sirf UART. > > Doesn't *-gpios being present imply having h/w > flow-control (i.e. microchip,uart-has-rtscts)? > > Rob Agreed. microchip,uart-has-rtscts will be dropped and it turns out we don't really need the rtc-gpios property. Josh > >> + >> +Example: >> + usart0: serial@1f822000 { >> + compatible = "microchip,pic32-usart"; >> + reg = <0x1f822000 0x50>; >> + interrupts = , >> + , >> + ; >> + pinctrl-names = "default"; >> + pinctrl-0 = < >> + &pinctrl_uart1 >> + &pinctrl_uart1_cts >> + &pinctrl_uart1_rts>; >> + microchip,uart-has-rtscts; >> + cts-gpios = <&pioB 15 0>; >> + rts-gpios = <&pioD 1 0>; >> + }; >> -- >> 1.7.9.5 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Henderson Subject: Re: [PATCH 09/14] DEVICETREE: Add bindings for PIC32 usart driver Date: Fri, 11 Dec 2015 09:16:30 -0700 Message-ID: <566AF6DE.9030803@microchip.com> References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-10-git-send-email-joshua.henderson@microchip.com> <20151122215622.GA32221@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151122215622.GA32221@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Rob, On 11/22/2015 02:56 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:21PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the USART peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../bindings/serial/microchip,pic32-usart.txt | 29 ++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> >> diff --git a/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> new file mode 100644 >> index 0000000..c87321c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> @@ -0,0 +1,29 @@ >> +* Microchip Universal Synchronous Asynchronous Receiver/Transmitter (USART) >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-usart" > > Again, should be more specific. > Ack. In addition, will replace all instances of USART with UART. >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for TX/RX/RTS/CTS >> + >> +Optional properties: >> +- microchip,uart-has-rtscts : Indicate the uart has hardware flow control >> +- rts-gpios: RTS pin for USP-based UART if microchip,uart-has-rtscts >> +- cts-gpios: CTS pin for USP-based UART if microchip,uart-has-rtscts > > This appears to just be copied for Sirf UART. > > Doesn't *-gpios being present imply having h/w > flow-control (i.e. microchip,uart-has-rtscts)? > > Rob Agreed. microchip,uart-has-rtscts will be dropped and it turns out we don't really need the rtc-gpios property. Josh > >> + >> +Example: >> + usart0: serial@1f822000 { >> + compatible = "microchip,pic32-usart"; >> + reg = <0x1f822000 0x50>; >> + interrupts = , >> + , >> + ; >> + pinctrl-names = "default"; >> + pinctrl-0 = < >> + &pinctrl_uart1 >> + &pinctrl_uart1_cts >> + &pinctrl_uart1_rts>; >> + microchip,uart-has-rtscts; >> + cts-gpios = <&pioB 15 0>; >> + rts-gpios = <&pioD 1 0>; >> + }; >> -- >> 1.7.9.5 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html