From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: generate labels at the beginning of unlikely sub-sections Date: Fri, 11 Dec 2015 16:55:03 +0000 Message-ID: <566AFFE7.6000603@citrix.com> References: <566AE0D802000078000BEAD2@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a7QyM-0005Wo-Uk for xen-devel@lists.xenproject.org; Fri, 11 Dec 2015 16:55:11 +0000 In-Reply-To: <566AE0D802000078000BEAD2@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On 11/12/15 13:42, Jan Beulich wrote: > This is to limit symbol table growth, which would be quite a bit worse > if we went with the "label every unlikely sub-section contribution" > approach proposed previously. > > Older gas doesn't support quoted symbols, yet the result looks quite > bit better that way. Hence two variants get introduced, one using > proper path names (including slashes and dashes) and one using path > names after converting them to valid symbol names (slashes and dashes > replaced). > > As a secondary adjustment also change the section name used with Clang. > > Signed-off-by: Jan Beulich (XEN) '1' pressed -> Extreme debugging in progress... (XEN) Xen WARN at /local/xen.git/xen/include/asm/hvm/vmx/vmx.h:329 (XEN) ----[ Xen-4.7-unstable x86_64 debug=y Not tainted ]---- (XEN) CPU: 0 (XEN) RIP: e008:[] traps.c#arch/x86/traps.o.unlikely+0/0x8 (XEN) Xen call trace: (XEN) [] traps.c#arch/x86/traps.o.unlikely+0/0x8 (XEN) [] handle_keypress+0xa4/0xd9 (XEN) [] console.c#__serial_rx+0x16/0x51 (XEN) [] console.c#serial_rx+0x8a/0x8f (XEN) [] serial_rx_interrupt+0x90/0xac (XEN) [] ns16550.c#ns16550_interrupt+0x57/0x71 (XEN) [] do_IRQ+0x582/0x629 (XEN) [] common_interrupt+0x62/0x70 (XEN) Looks good. Reviewed-by: Andrew Cooper