From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
To: blauwirbel@gmail.com, cornelia.huck@de.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions
Date: Fri, 11 Dec 2015 13:31:59 -0500 [thread overview]
Message-ID: <566B169F.8020305@linux.vnet.ibm.com> (raw)
In-Reply-To: <1449845523-22177-1-git-send-email-jjherne@linux.vnet.ibm.com>
On 12/11/2015 09:52 AM, Jason J. Herne wrote:
> We don't want newlines embedded in error messages. This seems to be a common
> problem with new code so let's try to catch it with checkpatch.
>
> This does not catch the newline when it is in a multiline statement. This is
> quite a bit more difficult and can be handled as follow on work.
>
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> ...
Ignore this one, I found some time to write up a better version that
handles the most common multi-line cases. See v2. Sorry for the spam :)
--
-- Jason J. Herne (jjherne@linux.vnet.ibm.com)
prev parent reply other threads:[~2015-12-11 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 14:52 [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions Jason J. Herne
2015-12-11 18:31 ` Jason J. Herne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566B169F.8020305@linux.vnet.ibm.com \
--to=jjherne@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.