From: Laura Abbott <labbott@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org, avri.altman@intel.com,
emmanuel.grumbach@intel.com, linuxwifi@intel.com,
linux-kernel@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id
Date: Fri, 11 Dec 2015 14:21:19 -0800 [thread overview]
Message-ID: <566B4C5F.4050908@redhat.com> (raw)
In-Reply-To: <1449821632-8106-1-git-send-email-johannes@sipsolutions.net>
On 12/11/2015 12:13 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Properly protect the RCU dereference in iwl_mvm_get_key_sta_id() when
> coming from iwl_mvm_update_tkip_key() which cannot hold the mvm->mutex
> by moving the call into the RCU critical section.
> Modify the check to use rcu_dereference_check() to permit this.
>
> Fixes: 9513c5e18a0d ("iwlwifi: mvm: Avoid dereferencing sta if it was already flushed")
> Reported-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Thanks, it's working for me.
Tested-by: Laura Abbott <labbott@redhat.com>
prev parent reply other threads:[~2015-12-11 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 23:22 Suspicious RCU from iwlwifi driver Laura Abbott
2015-12-11 8:00 ` Johannes Berg
2015-12-11 8:13 ` [PATCH] iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id Johannes Berg
2015-12-11 22:21 ` Laura Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566B4C5F.4050908@redhat.com \
--to=labbott@redhat.com \
--cc=avri.altman@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.