Re: [Printing-architecture] Contributing braille embosser support

[Till Kamppeter <till.kamppeter@gmail.com>]

On 12/10/2015 10:31 PM, Samuel Thibault wrote:
> Till Kamppeter, on Thu 10 Dec 2015 22:19:54 -0200, wrote:
>> I think MIT would be best.
>
> Here is a tarball with fixed copyrights.  I have also moved the shell
> helpers to /usr/share instead of /usr/lib since they are
> architecture-independent.
>
> Samuel
>

Thank you very much for the tarball.

I have integrated your software in cups-filters now and committed it to 
the BZR repository. Please download and try, and tell me whether 
everything is working.

I have the following remarks:

- I have integrated your files into the build system of cups-filters 
following all free software standards. Especially the configure script 
of cups-filters checks the presence of liblouis and also takes an 
"--enable-braille"/"--disable-braille" command line option pair. with 
Braille support being enabled by default if liblouis is present. Paths 
in the scripts are fitted to the system by configure, therefore the 
scripts in the source are *.in files with "@...@" placeholders.

- PPD files are not pre-built by the Makefile. The *.drv and *.defs 
files are put into the standard places in the CUPS directories, so that 
PPDs are generated on-the-fly.

- Documentation of the README and TODO files is joined to the README 
file of cups-filters.

- Your name is in the COPYING file now.

- There are three files which I have dropped as they do not get used (no 
reference to them in the other files): drivers/generic/fr.po, 
drivers/index/fr.po, and drivers/index/ubrlto4dot.c. For what are these 
files used, especially what does drivers/index/ubrlto4dot.c do?

- I have dropped the debian/ directory. Upstream packages should never 
ship a debian/ directory, independent if it contains the files for 
generating Debian packages or something else.

- The Generic embosser PPD file passes cupstestppd, the files for the 
Index printers not. The error message is:

**FAIL**  Multiple occurrences of option IndexTable choice name 24.

and indeed the option "IndexTable" has two choices with "24" as short 
name. As I do not have the printers, I do not know how to fix this 
correctly. Can you fix this? (Found by running the command 
"/usr/lib/cups/daemon/cups-driverd cat drv:///indexv4.drv/ibrlbox4.ppd | 
cupstestppd -" on a system with the current state of the cups-filters 
BZR installed).

Thanks again for your great contribution.

    Till