From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7hWO-0007Dx-4S for qemu-devel@nongnu.org; Sat, 12 Dec 2015 05:35:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7hWK-0007z4-VN for qemu-devel@nongnu.org; Sat, 12 Dec 2015 05:35:24 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:52448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7hWK-0007ys-MS for qemu-devel@nongnu.org; Sat, 12 Dec 2015 05:35:20 -0500 References: <1449694457-5843-1-git-send-email-karcher@physik.fu-berlin.de> <1449694457-5843-2-git-send-email-karcher@physik.fu-berlin.de> <5668A52C.1070408@vivier.eu> <566BEEFD.5010809@fu-berlin.de> From: Laurent Vivier Message-ID: <566BF859.1060704@vivier.eu> Date: Sat, 12 Dec 2015 11:35:05 +0100 MIME-Version: 1.0 In-Reply-To: <566BEEFD.5010809@fu-berlin.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Karcher , Michael Karcher , Riku Voipio , qemu-devel@nongnu.org Cc: glaubitz@physik.fu-berlin.de Le 12/12/2015 10:55, Michael Karcher a écrit : > On 09.12.2015 23:03, Laurent Vivier wrote: >> >> Le 09/12/2015 21:54, Michael Karcher a écrit : >>> do_rt_sigreturn forgets to initialize the signal mask variable before >>> trying to use it to restore the mask, so the signal mask is undefined >>> after do_rt_sigreturn. This bug has been in all the time since >>> 7181155d when do_rt_sigreturn was implemented for m68k. >>> [...] > BTW: documentation of the stack frame / signature for non-SA_SIGINFO > signal handlers seems to be quite lacking. There is a remark in the > sigaction manpage, but that one obviously only applies to i386... The best documentation is the kernel source: if you have a look at it you will see that these functions (setup_frame(), do_sigreturn(), ...) are just QEMU "translated" copy&paste. Laurent