All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Duncan <lduncan@suse.com>
To: emilne@redhat.com
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Hannes Reinecke <hare@suse.de>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tejun Heo <tj@kernel.org>, Hannes Reinecke <hare@suse.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management
Date: Sun, 13 Dec 2015 11:16:00 -0800	[thread overview]
Message-ID: <566DC3F0.6050206@suse.com> (raw)
In-Reply-To: <1449847911.4067.200.camel@localhost.localdomain>

On 12/11/2015 07:31 AM, Ewan Milne wrote:
> On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote:
>> On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>>>> "Lee" == Lee Duncan <lduncan@suse.com> writes:
>>>
>>> Lee> Martin: I will be glad to update the patch, creating a modprobe
>>> Lee> parameter as suggested, if you find this acceptable.
>>>
>>> For development use a module parameter would be fine. But I am concerned
>>> about our support folks that rely on the incrementing host number when
>>> analyzing customer log files.
>>>
>>> Ewan: How do you folks feel about this change?
>>>
>>
>> Ewan?
> 
> 
> Personally, I think having host numbers that increase essentially
> without limit (I think I've seen this with iSCSI sessions) are a
> problem, the numbers start to lose meaning for people when they
> are not easily recognizable.  Yes, it can help when you're analyzing
> a log file, but it seems to me that you would want to track the
> host state throughout anyway, so you could just follow the number
> as it changes.
> 
> If we change the behavior, we have to change documentation, and
> our support people will get calls.  But that's not a reason not
> to do it.
> 
> -Ewan
> 

Ewan:

Thank you for your reply. I agree with you, which is why I generated
this patch.

If we *do* make this change, do you think it would be useful to have a
module option to revert to the old numbering behavior? I actually think
it would be more confusing to support two behaviors than it would be to
bite the bullet (so to speak) and make the change.

-- 
Lee Duncan

  reply	other threads:[~2015-12-13 19:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 23:51 [PATCHv4 0/1] Update SCSI hosts to use ida for host number mgmt Lee Duncan
2015-10-07 23:51 ` [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management Lee Duncan
2015-10-14 12:22   ` Johannes Thumshirn
2015-10-14 13:55   ` James Bottomley
2015-10-14 18:34     ` Lee Duncan
2015-10-14 18:53       ` James Bottomley
2015-10-14 21:21         ` Lee Duncan
2015-10-15  5:52         ` Hannes Reinecke
2015-10-16 20:03         ` Lee Duncan
2015-10-16 20:03           ` Lee Duncan
2015-10-16 20:14           ` Greg KH
2015-10-16 20:14             ` Greg KH
2015-11-12 16:31         ` Lee Duncan
2015-11-13 21:54           ` Martin K. Petersen
2015-11-16 12:10             ` Hannes Reinecke
2015-11-16 21:47               ` Lee Duncan
2015-11-17 23:20                 ` Martin K. Petersen
2015-12-10 21:48                   ` Lee Duncan
2015-12-11 15:31                     ` Ewan Milne
2015-12-13 19:16                       ` Lee Duncan [this message]
2015-12-14 15:07                         ` Ewan Milne
2015-12-14 15:29                           ` Hannes Reinecke
2015-12-14 15:29                             ` Hannes Reinecke
2015-12-15  1:55                             ` Martin K. Petersen
2015-12-17 19:24                               ` Lee Duncan
2016-01-04 19:45                                 ` Lee Duncan
2016-01-05 23:53                                   ` Martin K. Petersen
2016-01-20 19:49                                     ` Lee Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566DC3F0.6050206@suse.com \
    --to=lduncan@suse.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.