From: Jason Wang <jasowang@redhat.com>
To: Dmitry Fleytman <dmitry@daynix.com>, Miao Yan <yanmiaobest@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3
Date: Mon, 14 Dec 2015 13:49:04 +0800 [thread overview]
Message-ID: <566E5850.2050902@redhat.com> (raw)
In-Reply-To: <30A41CCC-9E05-409A-AE84-043A3F14A2E8@daynix.com>
On 12/08/2015 02:29 PM, Dmitry Fleytman wrote:
>
> Reviewed-by: Dmitry Fleytman <dmitry@daynix.com
> <mailto:dmitry@daynix.com>>
>
>> On 8 Dec 2015, at 07:28 AM, Miao Yan <yanmiaobest@gmail.com
>> <mailto:yanmiaobest@gmail.com>> wrote:
>>
>> This patchset fixes debug macro pattern for vmxnet3. The old style uses
>> #ifdef...#else...#endif to define debug macros, as a result
>> the format string inside the macro will never be checked
>> (debug not turned on by default) and is likely to cause build
>> errors in the future when enabled.
>>
>> Changes in v3:
>> - fix a build error on 32 bit platforms
>>
>> Changes in v2:
>> - fix grammar errors in commit log
>>
>> Miao Yan (4):
>> net/vmxnet3: fix a build error when enabling debug output
>> net/vmxnet3: use %zu for size_t in printf
>> net/vmxnet3: fix debug macro pattern for vmxnet3
>> net/vmxnet3: remove redundant VMW_SHPRN(...) definition
>>
>> hw/net/vmware_utils.h | 5 +-
>> hw/net/vmxnet3.c | 8 +--
>> hw/net/vmxnet_debug.h | 139
>> +++++++++++++++++++++++++++++++-------------------
>> 3 files changed, 91 insertions(+), 61 deletions(-)
>>
>> --
>> 1.9.1
>>
>
Queued for 2.6.
Thanks
prev parent reply other threads:[~2015-12-14 5:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 5:28 [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3 Miao Yan
2015-12-08 5:28 ` [Qemu-devel] [PATCH v3 1/4] net/vmxnet3: fix a build error when enabling debug output Miao Yan
2015-12-08 5:28 ` [Qemu-devel] [PATCH v3 2/4] net/vmxnet3: use %zu for size_t in printf Miao Yan
2015-12-08 5:28 ` [Qemu-devel] [PATCH v3 3/4] net/vmxnet3: fix debug macro pattern for vmxnet3 Miao Yan
2015-12-08 5:28 ` [Qemu-devel] [PATCH v3 4/4] net/vmxnet3: remove redundant VMW_SHPRN(...) definition Miao Yan
2015-12-08 6:29 ` [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3 Dmitry Fleytman
2015-12-14 5:49 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566E5850.2050902@redhat.com \
--to=jasowang@redhat.com \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=yanmiaobest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.