From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 01/15] drm: omapdrm: Fix plane state free in plane reset handler Date: Mon, 14 Dec 2015 09:59:45 +0200 Message-ID: <566E76F1.70301@ti.com> References: <1449268039-24682-1-git-send-email-laurent.pinchart@ideasonboard.com> <1449268039-24682-2-git-send-email-laurent.pinchart@ideasonboard.com> <566821E7.8030202@ti.com> <103576498.oQSQlJ3ayB@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0484791229==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 493C86E1D7 for ; Sun, 13 Dec 2015 23:59:53 -0800 (PST) In-Reply-To: <103576498.oQSQlJ3ayB@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0484791229== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vjP4CmrQpMv6bwQkD4NrkccwN8V3KXR5A" --vjP4CmrQpMv6bwQkD4NrkccwN8V3KXR5A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13/12/15 22:39, Laurent Pinchart wrote: >> This one moves the function, so it's pretty hard to see what actually >> was changed. >=20 > It's unfortunately needed if we want to avoid forward declarations. I c= ould=20 > split the patch in two, but given the size of the function and the exte= nt of=20 > the change I thought it wouldn't be worth it. Maybe not, if everything goes perfectly and the patch is never applied to any other kernel tree. But if there is a single change to the function, or to the surrounding lines, having the fix and the move in the same patch makes resolving the conflict much harder. Tomi --vjP4CmrQpMv6bwQkD4NrkccwN8V3KXR5A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWbnbxAAoJEPo9qoy8lh71At0P/2F5vaTDlSriKf18N3Vq4qsV 9jKicC4QhP0xuTHHLCuLlsswI6YqmZtnZ6XfD2Ov9hXFfgvu2ZD9qcJmRQz8YKjx Ek0mwu/Vil5XNZkYeJEfUB7ekkVaBORc0optQ0YapvWkZDZqIqBvmCHgUlKHINkd t60jqC9ZhGeeelsB9LWE8Id0ztthVKshKYJTVCqtiVuFolbyCG9++ent2sVMSc13 pSq31E+EKpR1mATAlXO4RdNqH/0+qrN0dFLc3RC99LTIo/yGhM8O3OcWPg5qj6wT kbmemTzHao5cGeqy10duPuXa/yXU/bjlOn7cQnP6jDrn2SEHaXOpOEz1AGRloQJz 8HjyonT/2lCz7oywb7CqSU5lSn4jOtX7ddXvY95Q+PfqeswVnazQ0jr85eJXD8cr pkdbLxmukyunwGIJ2R3jxfzzJN1V7wxUSpc2wVh7c/BT4azP4DBNvD5P/6p2/5fo rujndCj4I9tX8VyH2ug2/TXAon9vuD9md4klEoAkeCbYtS9ux2JDdHy9nFXkVndQ vHG+42qMhdWNQD+SWcsl2hG08iqDT4Fj0UTucrKohxE8v/fzvRp3m3FtrUkwjI1X MY9WkZB6pSXcUrsXqhMY10VOvH3KJ2eG/kEX/Wk+Mab6lyeWjsGKi6IhAz+hm8+h PmUtgEswfdzRVeb008UG =iIV5 -----END PGP SIGNATURE----- --vjP4CmrQpMv6bwQkD4NrkccwN8V3KXR5A-- --===============0484791229== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0484791229==--