From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 0/3] leds: avoid module usage in non-modular code Date: Mon, 14 Dec 2015 10:21:39 +0100 Message-ID: <566E8A23.60108@samsung.com> References: <1450043151-30820-1-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1450043151-30820-1-git-send-email-paul.gortmaker@windriver.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Bryan Wu , Linus Walleij , Richard Purdie , linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org On 12/13/2015 10:45 PM, Paul Gortmaker wrote: > This series of commits is a part of a larger project to ensure > people don't reference modular support functions in non-modular > code. Overall there was roughly 5k lines of dead code in the > kernel due to this. So far we've fixed several areas, like tty, > x86, net, ... and we continue to work on other areas. > > There are several reasons to not use module support for code that > can never be built as a module, but the big ones are: > > (1) it is easy to accidentally code up unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else. > > For the LED subsystem, there are just three commits. Two are basically > trivial remapping to the appropriate non-modular counterparts. The > third also has a change to block driver unbinding since that doesn't > make any sense and it allows us to delete the .remove code. We've > already made similar unbind changes like this in drivers/tty. > > Patches created on linux-next and build tested for ARM allmodconfig. > > Paul. > --- > > Cc: Bryan Wu > Cc: Linus Walleij > Cc: Jacek Anaszewski > Cc: Richard Purdie > Cc: linux-leds@vger.kernel.org > > Paul Gortmaker (3): > drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular > drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular > drivers/leds: make leds-syscon.c explicitly non-modular > > drivers/leds/leds-syscon.c | 18 +++--------------- > drivers/leds/trigger/ledtrig-cpu.c | 26 +------------------------- > drivers/leds/trigger/ledtrig-ide-disk.c | 14 +------------- > 3 files changed, 5 insertions(+), 53 deletions(-) > Patch set applied, thanks. -- Best Regards, Jacek Anaszewski