From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932272AbbLNK2Y (ORCPT ); Mon, 14 Dec 2015 05:28:24 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:12622 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932138AbbLNK2V (ORCPT ); Mon, 14 Dec 2015 05:28:21 -0500 X-AuditID: cbfec7f5-f79b16d000005389-71-566e99c21ba7 Subject: Re: [PATCH 11/38] HSI: omap_ssi: fix handling ida_simple_get result To: linux-kernel@vger.kernel.org References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-12-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , Sebastian Reichel From: Andrzej Hajda Message-id: <566E997F.7060402@samsung.com> Date: Mon, 14 Dec 2015 11:27:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1442842450-29769-12-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t/xK7qHZuaFGax4YW2xccZ6VovLu+aw Waw9cpfd4vTuEgcWj02rOtk8+rasYvT4vEkugDmKyyYlNSezLLVI3y6BK+PAjCeMBXM5K+au P8PewHicvYuRk0NCwESi/+InJghbTOLCvfVsILaQwFJGiTsPrLsYuYDs54wS679dZAVJCAv4 SBzZ/ZMFxBYRUJDY3PuMFaKhTuLKlENsIA3MAt2MEssvvQabyiagKfF3802wqbwCWhLfP31i BrFZBFQlTu5oAmrm4BAViJBYtCMTokRQ4sfkeywgYU4BV4mHpz1BTGYBPYn7F7VAKpgF5CU2 r3nLPIFRYBaShlkIVbOQVC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERKqX3cwLj1m dYhRgINRiYc3Y1lumBBrYllxZe4hRgkOZiUR3gSrvDAh3pTEyqrUovz4otKc1OJDjNIcLEri vDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MOqv38z5ntv5n0RQQsN/ZSuWK1LhkXzOPwOa8niP Xr1QIV9mz9lu9p7fdZe6jP0URyHBg5vv5LodWl5RE6t384Lxelnrgilm3mxVwXMeNr+Yt8Yj LCjl+zfOas0J10xbeHZfuhV88YNSavf8V4odx8457p6zrfiCWArPHplUY+eYFovuoAkblFiK MxINtZiLihMBpx3kOlECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ping - almost three months passed. Regards Andrzej On 09/21/2015 03:33 PM, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda > --- > drivers/hsi/controllers/omap_ssi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/hsi/controllers/omap_ssi.c b/drivers/hsi/controllers/omap_ssi.c > index 089c6c3..5d9225f 100644 > --- a/drivers/hsi/controllers/omap_ssi.c > +++ b/drivers/hsi/controllers/omap_ssi.c > @@ -336,11 +336,10 @@ static int __init ssi_add_controller(struct hsi_controller *ssi, > return -ENOMEM; > } > > - ssi->id = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); > - if (ssi->id < 0) { > - err = ssi->id; > + err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); > + if (err < 0) > goto out_err; > - } > + ssi->id = err; > > ssi->owner = THIS_MODULE; > ssi->device.parent = &pd->dev;