From: Rik van Riel <riel@redhat.com>
To: Ani Sinha <ani@arista.com>, Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Richard Weinberger <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ivan Delalande <colona@arista.com>,
fruggeri <fruggeri@arista.com>
Subject: Re: new warning on sysrq kernel crash trigger
Date: Mon, 14 Dec 2015 12:07:08 -0500 [thread overview]
Message-ID: <566EF73C.3090505@redhat.com> (raw)
In-Reply-To: <CAOxq_8MM08-7AdUf5QxH_er7n5OMiiw7iRNZ2ZsOSWRFrQD9CQ@mail.gmail.com>
On 12/14/2015 11:24 AM, Ani Sinha wrote:
> Rik, any comments?
Another good option is to simply ignore this warning, or drop
the rcu_read_lock before doing the alt-syrsq-c action.
After all, alt-sysrq-c is "crash the system, take a crash dump",
which is not an action the system ever returns from.
static struct sysrq_key_op sysrq_crash_op = {
.handler = sysrq_handle_crash,
.help_msg = "crash(c)",
.action_msg = "Trigger a crash",
.enable_mask = SYSRQ_ENABLE_DUMP,
};
--
All rights reversed
next prev parent reply other threads:[~2015-12-14 17:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 23:57 new warning on sysrq kernel crash trigger Ani Sinha
2015-12-11 5:26 ` Paul E. McKenney
2015-12-11 18:50 ` Ani Sinha
2015-12-11 20:44 ` Ani Sinha
2015-12-11 21:25 ` Paul E. McKenney
2015-12-11 22:10 ` Rik van Riel
2015-12-11 22:27 ` Paul E. McKenney
2015-12-11 23:41 ` Ani Sinha
2015-12-12 0:02 ` Paul E. McKenney
2015-12-12 0:11 ` Ani Sinha
2015-12-12 0:16 ` Ani Sinha
2015-12-12 1:03 ` Paul E. McKenney
2015-12-14 16:24 ` Ani Sinha
2015-12-14 17:07 ` Rik van Riel [this message]
2015-12-15 0:14 ` Anirban Sinha
2015-12-16 0:52 ` Ani Sinha
2015-12-16 16:25 ` Rik van Riel
2015-12-17 17:28 ` Greg KH
2015-12-18 1:18 ` Ani Sinha
2015-12-16 16:22 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566EF73C.3090505@redhat.com \
--to=riel@redhat.com \
--cc=ani@arista.com \
--cc=colona@arista.com \
--cc=fruggeri@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.