From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen: building with perfc=y was broken
Date: Mon, 14 Dec 2015 17:50:48 +0000
Message-ID: <566F0178.101@citrix.com>
References: <20151214174528.16873.64887.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7834eabc7=Andrew.Cooper3@citrix.com>)
	id 1a8XGw-00083r-Di
	for xen-devel@lists.xenproject.org; Mon, 14 Dec 2015 17:50:54 +0000
In-Reply-To: <20151214174528.16873.64887.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: Paul Durrant <Paul.Durrant@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 14/12/15 17:45, Dario Faggioli wrote:
> because of b38d426ad09 ("x86/viridian: flush remote tlbs
> by hypercall") which was defining mshv_call_flush, but using
> mshv_flush.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Paul Durrant <Paul.Durrant@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

FYI, when the Kconfig series lands, I plan to port the Linux
IS_ENABLED() infrastructure to Xen, which will allow bugs like this to
be caught by the compiler even when the option is disabled.

~Andrew