From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: mpc85xx: Move set_liodns, setup_portals to common boot seq
Date: Tue, 15 Dec 2015 10:57:12 +0800 [thread overview]
Message-ID: <566F8188.5070009@freescale.com> (raw)
In-Reply-To: <1446799456-22322-1-git-send-email-prabhakar@freescale.com>
On 11/06/2015 04:44 PM, Prabhakar Kushwaha wrote:
> Users migrating Freescale's PowerPC SoC U-Boot code to their custom
> board, often overlook the need to execute set_liodns() and
> setup_portals() being called by platform files.
>
> So Move set_liodns() and setup_portals() to common u-boot boot
> sequence
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> arch/powerpc/cpu/mpc85xx/cpu_init.c | 7 +++++++
> board/freescale/b4860qds/b4860qds.c | 5 -----
> board/freescale/corenet_ds/corenet_ds.c | 6 ------
> board/freescale/p2041rdb/p2041rdb.c | 3 ---
> board/freescale/t102xqds/t102xqds.c | 5 -----
> board/freescale/t102xrdb/t102xrdb.c | 5 -----
> board/freescale/t1040qds/t1040qds.c | 5 -----
> board/freescale/t104xrdb/t104xrdb.c | 6 ------
> board/freescale/t208xqds/t208xqds.c | 6 ------
> board/freescale/t208xrdb/t208xrdb.c | 6 ------
> board/freescale/t4qds/t4240emu.c | 6 ------
> board/freescale/t4qds/t4240qds.c | 6 ------
> board/freescale/t4rdb/t4240rdb.c | 6 ------
> 13 files changed, 7 insertions(+), 65 deletions(-)
Prabhakar,
This change is not good. You presume set_liodns() is available for all 85xx.
Putting the call into cpu_init.c caused compiling error for non-corenet SoCs.
Please update and make sure you run buildman on powerpc.
York
prev parent reply other threads:[~2015-12-15 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 8:44 [U-Boot] [PATCH] powerpc: mpc85xx: Move set_liodns, setup_portals to common boot seq Prabhakar Kushwaha
2015-12-15 2:57 ` York Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566F8188.5070009@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.