From: Jaehoon Chung <jh80.chung@samsung.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: It is not an error for the card to be removed while suspended
Date: Tue, 15 Dec 2015 13:01:04 +0900 [thread overview]
Message-ID: <566F9080.6030903@samsung.com> (raw)
In-Reply-To: <1450101087-24391-1-git-send-email-adrian.hunter@intel.com>
Hi, Adrian.
On 12/14/2015 10:51 PM, Adrian Hunter wrote:
> A card can be removed while it is runtime suspended.
> Do not print an error message.
Well, if card is non-removable (in case of eMMC, card can be non-removable),
it needs to print the error message?
I'm not sure what's correct..but just my opinion.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> drivers/mmc/core/sd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 549c56e8cf6b..bf49e44571f2 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1935,7 +1935,7 @@ static int mmc_runtime_resume(struct mmc_host *host)
> int err;
>
> err = _mmc_resume(host);
> - if (err)
> + if (err && err != -ENOMEDIUM)
> pr_err("%s: error %d doing runtime resume\n",
> mmc_hostname(host), err);
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 8f3b46a56b3d..f2b164b214ae 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -1158,7 +1158,7 @@ static int mmc_sd_runtime_resume(struct mmc_host *host)
> int err;
>
> err = _mmc_sd_resume(host);
> - if (err)
> + if (err && err != -ENOMEDIUM)
> pr_err("%s: error %d doing runtime resume\n",
> mmc_hostname(host), err);
>
>
next prev parent reply other threads:[~2015-12-15 4:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 13:51 [PATCH] mmc: It is not an error for the card to be removed while suspended Adrian Hunter
2015-12-15 4:01 ` Jaehoon Chung [this message]
2015-12-16 8:18 ` Adrian Hunter
2015-12-18 9:54 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566F9080.6030903@samsung.com \
--to=jh80.chung@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.