From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()
Date: Tue, 15 Dec 2015 16:40:14 +0800 [thread overview]
Message-ID: <566FD1EE.9000203@wytron.com.tw> (raw)
In-Reply-To: <35b1d35839a0e87cf54aeafb9d9eaada349f306a.1450108392.git.michal.simek@xilinx.com>
Hi Michal,
On 2015?12?14? 23:53, Michal Simek wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/serial/serial_xuartlite.c | 2 +-
> drivers/serial/serial_zynq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index fe87b515d902..0238a52380c7 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
> };
>
> #ifdef CONFIG_DEBUG_UART_UARTLITE
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
> {
> struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
>
> diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
> index b2b98dea1561..3430482f8d8b 100644
> --- a/drivers/serial/serial_zynq.c
> +++ b/drivers/serial/serial_zynq.c
> @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
> };
>
> #ifdef CONFIG_DEBUG_UART_ZYNQ
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
> {
> struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
>
>
Reviewed-by: Thomas Chou <thomas@wytron.com.tw>
Thanks,
Thomas
prev parent reply other threads:[~2015-12-15 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 15:53 [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init() Michal Simek
2015-12-14 22:14 ` Simon Glass
2015-12-15 4:20 ` Bin Meng
2015-12-15 15:29 ` Michal Simek
2015-12-15 8:40 ` Thomas Chou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FD1EE.9000203@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.