From: Or Gerlitz <ogerlitz@mellanox.com>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
Eran Ben Elisha <eranbe@mellanox.com>,
Hadar Hen Zion <hadarh@mellanox.com>,
Moni Shoua <monis@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>,
Maor Gottlieb <maorg@mellanox.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port
Date: Tue, 15 Dec 2015 11:09:40 +0200 [thread overview]
Message-ID: <566FD8D4.5030506@mellanox.com> (raw)
In-Reply-To: <1450087564-28441-1-git-send-email-a.hajda@samsung.com>
On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
Please add here
Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
otherwise, Looks good
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Or.
next prev parent reply other threads:[~2015-12-15 9:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 10:05 [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Andrzej Hajda
2015-12-14 10:05 ` [PATCH] doc: mei: fix handling return value of mei_recv_msg Andrzej Hajda
2015-12-14 12:04 ` Winkler, Tomas
2015-12-14 10:06 ` [PATCH] clk: sunxi: fix handling return value of of_property_match_string Andrzej Hajda
2015-12-14 10:06 ` Andrzej Hajda
2015-12-14 13:05 ` Maxime Ripard
2015-12-14 13:05 ` Maxime Ripard
2015-12-14 10:06 ` [ath9k-devel] [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
2015-12-14 10:06 ` Andrzej Hajda
2015-12-14 10:06 ` Andrzej Hajda
2015-12-31 13:12 ` [ath9k-devel] " Kalle Valo
2015-12-31 13:12 ` Kalle Valo
2015-12-31 13:12 ` Kalle Valo
2015-12-31 13:12 ` Kalle Valo
2015-12-14 10:06 ` [PATCH] extcon: max14577: fix handling return value of regmap_irq_get_virq Andrzej Hajda
2015-12-14 10:31 ` Krzysztof Kozlowski
2015-12-14 11:12 ` [PATCH] extcon: max77693: " Andrzej Hajda
2015-12-15 0:22 ` Krzysztof Kozlowski
2015-12-15 1:08 ` Chanwoo Choi
2015-12-15 1:08 ` [PATCH] extcon: max14577: " Chanwoo Choi
2015-12-14 10:06 ` [PATCH] extcon: max77843: " Andrzej Hajda
2015-12-14 10:30 ` Krzysztof Kozlowski
2015-12-15 1:08 ` Chanwoo Choi
2015-12-14 10:06 ` [PATCH] be2iscsi: fix handling return value of mgmt_open_connection Andrzej Hajda
2015-12-15 9:09 ` Or Gerlitz [this message]
2015-12-15 16:55 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FD8D4.5030506@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=hadarh@mellanox.com \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maorg@mellanox.com \
--cc=monis@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.