From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] net: emac: emac gigabit ethernet controller driver Date: Tue, 15 Dec 2015 09:17:00 -0600 Message-ID: <56702EEC.8000506@codeaurora.org> References: <1450138740-32562-1-git-send-email-gavidov@codeaurora.org> <566F6F3D.5050004@gmail.com> <567023F8.80302@codeaurora.org> <1594472.ixZvj6PYdz@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1594472.ixZvj6PYdz@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann , Christopher Covington Cc: Florian Fainelli , Gilad Avidov , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sdharia-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, vikrams-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org Arnd Bergmann wrote: > We generally want to use readl/writel rather than the relaxed versions, > unless it is in performance-critical code. What about if we have 20+ writes in a row, for example, when initializing a part? I've seen code like this: writel_relaxed(...); writel_relaxed(...); writel_relaxed(...); ... writel(...); // HW now inited, so enable -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933637AbbLOPRH (ORCPT ); Tue, 15 Dec 2015 10:17:07 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60518 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932734AbbLOPRE (ORCPT ); Tue, 15 Dec 2015 10:17:04 -0500 Subject: Re: [PATCH] net: emac: emac gigabit ethernet controller driver To: Arnd Bergmann , Christopher Covington Cc: Florian Fainelli , Gilad Avidov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, shankerd@codeaurora.org, gregkh@linuxfoundation.org, vikrams@codeaurora.org References: <1450138740-32562-1-git-send-email-gavidov@codeaurora.org> <566F6F3D.5050004@gmail.com> <567023F8.80302@codeaurora.org> <1594472.ixZvj6PYdz@wuerfel> From: Timur Tabi Message-ID: <56702EEC.8000506@codeaurora.org> Date: Tue, 15 Dec 2015 09:17:00 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <1594472.ixZvj6PYdz@wuerfel> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann wrote: > We generally want to use readl/writel rather than the relaxed versions, > unless it is in performance-critical code. What about if we have 20+ writes in a row, for example, when initializing a part? I've seen code like this: writel_relaxed(...); writel_relaxed(...); writel_relaxed(...); ... writel(...); // HW now inited, so enable -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.