All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Brace <brace77070@gmail.com>
To: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
Cc: Viswas.G@pmcs.com, scott.teel@pmcs.com, Kevin.Barnett@pmcs.com,
	scott.benesh@pmcs.com, Mahesh.Rajashekhara@pmcs.com,
	hch@infradead.org, Justin.Lindley@pmcs.com, elliott@hpe.com,
	james.bottomley@parallels.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.
Date: Tue, 15 Dec 2015 09:25:57 -0600	[thread overview]
Message-ID: <56703105.9050109@pmcs.com> (raw)
In-Reply-To: <C8F529F3-D668-473E-92D5-5261A147B9E5@linux.vnet.ibm.com>

On 12/09/2015 05:21 PM, Matthew R. Ochs wrote:
>> On Dec 9, 2015, at 3:18 PM, Don Brace <don.brace@pmcs.com> wrote:
>>
>> sas transport places devices on bus 0 but driver was setting
>> the bus to 3.
>>
>> Reviewed-by: Justin Lindley <justin.lindley@pmcs.com>
>> Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com>
>> Reviewed-by: Scott Teel <scott.teel@pmcs.com>
>> Signed-off-by: Don Brace <don.brace@pmcs.com>
>> ---
>> drivers/scsi/hpsa.h |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
>> index ae5beda..fdd39fc 100644
>> --- a/drivers/scsi/hpsa.h
>> +++ b/drivers/scsi/hpsa.h
>> @@ -400,7 +400,7 @@ struct offline_device_entry {
>> #define HPSA_PHYSICAL_DEVICE_BUS	0
>> #define HPSA_RAID_VOLUME_BUS		1
>> #define HPSA_EXTERNAL_RAID_VOLUME_BUS	2
>> -#define HPSA_HBA_BUS			3
>> +#define HPSA_HBA_BUS			0
> Is this not the same as using HPSA_PHYSICAL_DEVICE_BUS?
I was just trying to minimize the changes. I can update the driver
is necessary.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2015-12-15 15:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 21:18 [PATCH 0/3] hpsa update Don Brace
2015-12-09 21:18 ` [PATCH 1/3] hpsa: fix path_info_show Don Brace
2015-12-09 23:15   ` Matthew R. Ochs
2015-12-09 21:18 ` [PATCH 2/3] hpsa: change SAS transport devices to bus 0 Don Brace
2015-12-09 23:21   ` Matthew R. Ochs
2015-12-15 15:25     ` Don Brace [this message]
2015-12-18 20:14       ` Matthew R. Ochs
2015-12-09 21:18 ` [PATCH 3/3] hpsa: add box and bay information for enclosure devices Don Brace
2015-12-09 23:41   ` Matthew R. Ochs
2015-12-18 20:19     ` Matthew R. Ochs
2015-12-21 17:09       ` Don Brace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56703105.9050109@pmcs.com \
    --to=brace77070@gmail.com \
    --cc=Justin.Lindley@pmcs.com \
    --cc=Kevin.Barnett@pmcs.com \
    --cc=Mahesh.Rajashekhara@pmcs.com \
    --cc=Viswas.G@pmcs.com \
    --cc=elliott@hpe.com \
    --cc=hch@infradead.org \
    --cc=james.bottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mrochs@linux.vnet.ibm.com \
    --cc=scott.benesh@pmcs.com \
    --cc=scott.teel@pmcs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.