From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource/drivers/dw_apb_timer: Fix apbt_readl return types
Date: Tue, 15 Dec 2015 21:42:20 +0100 [thread overview]
Message-ID: <56707B2C.30501@linaro.org> (raw)
In-Reply-To: <1448466083-5182-1-git-send-email-jszhang@marvell.com>
On 11/25/2015 04:41 PM, Jisheng Zhang wrote:
> On Marvell BG4CT platform, we observed the __apbt_read_clocksource()
> return wrong value: Let's assume the APBTMR_N_CURRENT_VALUE value is
> 0xf0000000, we got 0xffffffff0fffffff, but it should be 0xfffffff.
>
> This issue should be common on all 64bit platforms. We fix the issue
> by letting aptb_readl() return u32. apbt_writel() is also updated
> to write u32 val rather than unsigned long.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
Applied.
Thanks !
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Jisheng Zhang <jszhang@marvell.com>, tglx@linutronix.de, arnd@arndb.de
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource/drivers/dw_apb_timer: Fix apbt_readl return types
Date: Tue, 15 Dec 2015 21:42:20 +0100 [thread overview]
Message-ID: <56707B2C.30501@linaro.org> (raw)
In-Reply-To: <1448466083-5182-1-git-send-email-jszhang@marvell.com>
On 11/25/2015 04:41 PM, Jisheng Zhang wrote:
> On Marvell BG4CT platform, we observed the __apbt_read_clocksource()
> return wrong value: Let's assume the APBTMR_N_CURRENT_VALUE value is
> 0xf0000000, we got 0xffffffff0fffffff, but it should be 0xfffffff.
>
> This issue should be common on all 64bit platforms. We fix the issue
> by letting aptb_readl() return u32. apbt_writel() is also updated
> to write u32 val rather than unsigned long.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
Applied.
Thanks !
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-12-15 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 15:41 [PATCH] clocksource/drivers/dw_apb_timer: Fix apbt_readl return types Jisheng Zhang
2015-11-25 15:41 ` Jisheng Zhang
2015-12-15 20:42 ` Daniel Lezcano [this message]
2015-12-15 20:42 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56707B2C.30501@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.