From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 15 Dec 2015 21:42:20 +0100 Subject: [PATCH] clocksource/drivers/dw_apb_timer: Fix apbt_readl return types In-Reply-To: <1448466083-5182-1-git-send-email-jszhang@marvell.com> References: <1448466083-5182-1-git-send-email-jszhang@marvell.com> Message-ID: <56707B2C.30501@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/25/2015 04:41 PM, Jisheng Zhang wrote: > On Marvell BG4CT platform, we observed the __apbt_read_clocksource() > return wrong value: Let's assume the APBTMR_N_CURRENT_VALUE value is > 0xf0000000, we got 0xffffffff0fffffff, but it should be 0xfffffff. > > This issue should be common on all 64bit platforms. We fix the issue > by letting aptb_readl() return u32. apbt_writel() is also updated > to write u32 val rather than unsigned long. > > Signed-off-by: Jisheng Zhang > --- Applied. Thanks ! -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965563AbbLOUmU (ORCPT ); Tue, 15 Dec 2015 15:42:20 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35079 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932365AbbLOUmR (ORCPT ); Tue, 15 Dec 2015 15:42:17 -0500 Subject: Re: [PATCH] clocksource/drivers/dw_apb_timer: Fix apbt_readl return types To: Jisheng Zhang , tglx@linutronix.de, arnd@arndb.de References: <1448466083-5182-1-git-send-email-jszhang@marvell.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Daniel Lezcano Message-ID: <56707B2C.30501@linaro.org> Date: Tue, 15 Dec 2015 21:42:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448466083-5182-1-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2015 04:41 PM, Jisheng Zhang wrote: > On Marvell BG4CT platform, we observed the __apbt_read_clocksource() > return wrong value: Let's assume the APBTMR_N_CURRENT_VALUE value is > 0xf0000000, we got 0xffffffff0fffffff, but it should be 0xfffffff. > > This issue should be common on all 64bit platforms. We fix the issue > by letting aptb_readl() return u32. apbt_writel() is also updated > to write u32 val rather than unsigned long. > > Signed-off-by: Jisheng Zhang > --- Applied. Thanks ! -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog