All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem Jan Withagen <wjw@digiware.nl>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: FreeBSD is receiving traps on os/FileJournal.cc:1036
Date: Wed, 16 Dec 2015 00:56:25 +0100	[thread overview]
Message-ID: <5670A8A9.3020708@digiware.nl> (raw)

Hi,

I'm receiving traps when running the tests going with 'gmake check'
and on one of the tests it traps on:

os/FileJournal.cc:1036
void FileJournal::align_bl(off64_t pos, bufferlist& bl)
{
  // make sure list segments are page aligned
  if (directio && (!bl.is_aligned(block_size) ||
                   !bl.is_n_align_sized(CEPH_MINIMUM_BLOCK_SIZE))) {
    assert(0 == "bl should be align");
    if ((bl.length() & (CEPH_MINIMUM_BLOCK_SIZE - 1)) != 0 ||
        (pos & (CEPH_MINIMUM_BLOCK_SIZE - 1)) != 0)
      dout(0) << "rebuild_page_aligned failed, " << bl << dendl;
    assert((bl.length() & (CEPH_MINIMUM_BLOCK_SIZE - 1)) == 0);
    assert((pos & (CEPH_MINIMUM_BLOCK_SIZE - 1)) == 0);
  }
}

And then I get confused with the following commit in other tests:
commit 8ed724222651812c2ee8cc3804dc1f54c973897d
Author: Kefu Chai <kchai@redhat.com>
Date:   Fri Sep 4 01:23:31 2015 +0800

    test/bufferlist: do not expect !is_page_aligned() after unaligned
rebuild

    if the size of a bufferlist is page aligned we allocate page aligned
    memory chunk for it when rebuild() is called. otherwise we just call
    the plain new() to allocate new memory chunk for holding the continuous
    buffer. but we should not expect that `new` allocator always returns
    unaligned memory chunks. instead, it *could* return page aligned
    memory chunk as long as the allocator feels appropriate. so, the
    `EXPECT_FALSE(bl.is_page_aligned())` after the `rebuild()` call is
    removed.

    Signed-off-by: Kefu Chai <kchai@redhat.com>

Could these 2 be related, and do I have an alignment problem when
allocating buffers and bufferlists....

Note that I also have not solved the illegal writes to _len in
bufferlists when running unittest_erasure_code_shec_arguments.

So any suggestions as to where to look at for this, are welcome.

--WjW


             reply	other threads:[~2015-12-16  0:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 23:56 Willem Jan Withagen [this message]
2015-12-16  1:57 ` FreeBSD is receiving traps on os/FileJournal.cc:1036 Xinze Chi (信泽)
2015-12-16  9:20   ` Willem Jan Withagen
2015-12-16  9:40     ` Xinze Chi (信泽)
2015-12-16 10:26       ` Willem Jan Withagen
2015-12-16 12:51         ` Xinze Chi (信泽)
2015-12-16 13:45           ` Willem Jan Withagen
2015-12-16 20:07           ` Willem Jan Withagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5670A8A9.3020708@digiware.nl \
    --to=wjw@digiware.nl \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.