From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v10 0/17] Add Analogix Core Display Port Driver Date: Wed, 16 Dec 2015 08:50:10 +0800 Message-ID: <5670B542.4060402@rock-chips.com> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <4659407.pYb0RRCQQX@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4659407.pYb0RRCQQX@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Krzysztof Kozlowski , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Andrzej Hajda , Gustavo Padovan , linux-samsung-soc@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , javier@osg.samsung.com, Thierry Reding , devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Jingoo Han , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Kyungmin Park , ajaynumb@gmail.com, Andy Yan List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28sCgpPbiAxMi8xNS8yMDE1IDA4OjA2IEFNLCBIZWlrbyBTdMO8Ym5lciB3cm90ZToK PiBIaSBZYWtpciwKPgo+IEFtIE1vbnRhZywgNy4gRGV6ZW1iZXIgMjAxNSwgMTQ6Mzc6MTkgc2No cmllYiBZYWtpciBZYW5nOgo+PiAgICAgVGhlIFNhbXN1bmcgRXh5bm9zIGVEUCBjb250cm9sbGVy IGFuZCBSb2NrY2hpcCBSSzMyODggZURQIGNvbnRyb2xsZXIKPj4gc2hhcmUgdGhlIHNhbWUgSVAs IHNvIGEgbG90IG9mIHBhcnRzIGNhbiBiZSByZS11c2VkLiBJIHNwbGl0IHRoZSBjb21tb24KPj4g Y29kZSBpbnRvIGJyaWRnZSBkaXJlY3RvcnksIHRoZW4gcmszMjg4IGFuZCBleHlub3Mgb25seSBu ZWVkIHRvIGtlZXAKPj4gc29tZSBwbGF0Zm9ybSBjb2RlLiBDYXVzZSBJIGNhbid0IGZpbmQgdGhl IGV4YWN0IElQIG5hbWUgb2YgZXh5bm9zIGRwCj4+IGNvbnRyb2xsZXIsIHNvIEkgZGVjaWRlIHRv IG5hbWUgZHAgY29yZSBkcml2ZXIgd2l0aCAiYW5hbG9naXgiIHdoaWNoIEkKPj4gZmluZCBpbiBy azMyODggZURQIFRSTQo+IHNvIGl0IGxvb2tzIGxpa2UgdGhlIGhvdHBsdWcgd29ya3MgbmljZWx5 IG5vdy4gSSB3YXMgYWJsZSB0byB0ZXN0IGl0Cj4gc3VjZXNzZnVsbHkgb24gYm90aCBhIEplcnJ5 IGFuZCBhIE1pbm5pZSBkZXZpY2Ugd2l0aG91dCBuZWVkaW5nIHRvIGZvcmNlCj4gaG90cGx1ZyA6 LSkgLgo+Cj4gQXMgSSBuZWVkZWQgdG8gYWRhcHQgc29tZSBwYXRjaGVzIHdoZW4gYXBwbHlpbmcg dGhlIGxhc3Rlc3Qgb25lcywgSSB0aGluayBpdAo+IHdvdWxkIGJlIGdvb2QgZm9yIGEgZnVsbCBz ZW5kIG9mIHRoZSBsYXRlc3QgdmVyc2lvbiBhcyB2MTEuCgpHb3QgaXQsIHdpbGwgc2VuZCBzb29u ICA7KQoKPiBXaGVuIGdvaW5nIG92ZXIgdGhlIHBhdGNoZXMgYmVmb3JlIHNlbmRpbmcsIHBsZWFz ZSBhbHNvIGZpeCB0aGUgaW5kZW50YXRpb24KPiBpc3N1ZXMgaW4gYW5hbG9naXhfZHBfY29yZS5o IC0gYm90aCBuZXdseSBhZGRlZCBlbGVtZW50cyB0byBhbmFsb2dpeF9kcF9kZXZpY2UKPiB1c2Ug c3BhY2VzIGJldHdlZW4gdHlwZSBhbmQgbmFtZSwgd2hlcmUgdGhlIHJlc3QgdXNlcyB0YWJzLgo+ IFtUaGlzIHNob3VsZCBvZiBjb3Vyc2UgYmUgZml4ZWQgaW4gdGhlIHBhdGNoZXMgYWRkaW5nIHRo ZXNlIGxpbmVzIDotKSBdCgpEb25lLAoKVGhhbmtzLAotIFlha2lyCgo+Cj4gSGVpa28KPgo+Cj4K CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Wed, 16 Dec 2015 08:50:10 +0800 Subject: [PATCH v10 0/17] Add Analogix Core Display Port Driver In-Reply-To: <4659407.pYb0RRCQQX@diego> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <4659407.pYb0RRCQQX@diego> Message-ID: <5670B542.4060402@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko, On 12/15/2015 08:06 AM, Heiko St?bner wrote: > Hi Yakir, > > Am Montag, 7. Dezember 2015, 14:37:19 schrieb Yakir Yang: >> The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller >> share the same IP, so a lot of parts can be re-used. I split the common >> code into bridge directory, then rk3288 and exynos only need to keep >> some platform code. Cause I can't find the exact IP name of exynos dp >> controller, so I decide to name dp core driver with "analogix" which I >> find in rk3288 eDP TRM > so it looks like the hotplug works nicely now. I was able to test it > sucessfully on both a Jerry and a Minnie device without needing to force > hotplug :-) . > > As I needed to adapt some patches when applying the lastest ones, I think it > would be good for a full send of the latest version as v11. Got it, will send soon ;) > When going over the patches before sending, please also fix the indentation > issues in analogix_dp_core.h - both newly added elements to analogix_dp_device > use spaces between type and name, where the rest uses tabs. > [This should of course be fixed in the patches adding these lines :-) ] Done, Thanks, - Yakir > > Heiko > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964953AbbLPAuY (ORCPT ); Tue, 15 Dec 2015 19:50:24 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:47044 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754424AbbLPAuV (ORCPT ); Tue, 15 Dec 2015 19:50:21 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v10 0/17] Add Analogix Core Display Port Driver To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <4659407.pYb0RRCQQX@diego> Cc: Inki Dae , Mark Yao , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Russell King , emil.l.velikov@gmail.com, Gustavo Padovan , Kishon Vijay Abraham I , ajaynumb@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <5670B542.4060402@rock-chips.com> Date: Wed, 16 Dec 2015 08:50:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <4659407.pYb0RRCQQX@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 12/15/2015 08:06 AM, Heiko Stübner wrote: > Hi Yakir, > > Am Montag, 7. Dezember 2015, 14:37:19 schrieb Yakir Yang: >> The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller >> share the same IP, so a lot of parts can be re-used. I split the common >> code into bridge directory, then rk3288 and exynos only need to keep >> some platform code. Cause I can't find the exact IP name of exynos dp >> controller, so I decide to name dp core driver with "analogix" which I >> find in rk3288 eDP TRM > so it looks like the hotplug works nicely now. I was able to test it > sucessfully on both a Jerry and a Minnie device without needing to force > hotplug :-) . > > As I needed to adapt some patches when applying the lastest ones, I think it > would be good for a full send of the latest version as v11. Got it, will send soon ;) > When going over the patches before sending, please also fix the indentation > issues in analogix_dp_core.h - both newly added elements to analogix_dp_device > use spaces between type and name, where the rest uses tabs. > [This should of course be fixed in the patches adding these lines :-) ] Done, Thanks, - Yakir > > Heiko > > >