From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] net: gem: Fix return value from recv
Date: Wed, 16 Dec 2015 09:05:43 +0100 [thread overview]
Message-ID: <56711B57.5000400@xilinx.com> (raw)
In-Reply-To: <CANr=Z=br3P2xH-28DfAte7+=FvYK272r+=4FmYCk304h4CU+tA@mail.gmail.com>
Hi Joe,
On 15.12.2015 20:51, Joe Hershberger wrote:
> Hi Michal,
>
> On Tue, Dec 15, 2015 at 11:47 AM, Joe Hershberger
> <joe.hershberger@gmail.com> wrote:
>> On Fri, Dec 11, 2015 at 5:43 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>>> recv function should return 0 instead of frame_len not to
>>> proceed the same packet again in core.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Oops. NAK. Didn't realize this was the top-level recv function being
> passed to the eth layer.
I expect that origin ACK was valid and you realized like for other
driver that here should be return 0 because separation with free_pkt is
done in 3/5.
Thanks,
Michal
next prev parent reply other threads:[~2015-12-16 8:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 11:43 [U-Boot] [PATCH 1/5] net: gem: Setup default phy address to -1 Michal Simek
2015-12-11 11:43 ` [U-Boot] [PATCH 2/5] net: gem: Fix return value from recv Michal Simek
2015-12-15 17:47 ` Joe Hershberger
2015-12-15 19:51 ` Joe Hershberger
2015-12-16 8:05 ` Michal Simek [this message]
2015-12-16 8:23 ` Joe Hershberger
2015-12-11 11:43 ` [U-Boot] [PATCH 3/5] net: gem: Separate recv and free_pkt functions Michal Simek
2015-12-15 17:49 ` Joe Hershberger
2015-12-11 11:43 ` [U-Boot] [PATCH 4/5] net: gem: Fix typo in Kconfig entry Michal Simek
2015-12-15 17:50 ` Joe Hershberger
2015-12-11 11:43 ` [U-Boot] [PATCH 5/5] net: gem: Add driver dependencies to PHYLIB and MII Michal Simek
2015-12-15 17:52 ` Joe Hershberger
2015-12-16 8:07 ` Michal Simek
2015-12-15 17:47 ` [U-Boot] [PATCH 1/5] net: gem: Setup default phy address to -1 Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56711B57.5000400@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.