All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options
Date: Wed, 16 Dec 2015 09:50:37 +0100	[thread overview]
Message-ID: <567125DD.7050500@redhat.com> (raw)
In-Reply-To: <567110D4.1040205@redhat.com>



On 16/12/2015 08:20, Thomas Huth wrote:
> Ah, ok, that makes more sense... anyway, "-device ?" also lists some
> devices like "ne2k_isa", ""usb-bt-dongle" and "vmxnet3" ... I somewhat
> doubt that we want to have these in the list of "-net nic" supported
> devices, too.

Why not?

> ... hmmm, by the way, why the heck do we have vmxnet3 on powerpc? Does
> that make sense at all?

By default all PCI devices are included in all targets, that's the
simple explanation. :)

>>>>>> The thing is, people are still running QEMU from the command line.
>>>>>>
>>>>>> "-net nic -net bridge,br=virbr0" is still much less of a mouthful than
>>>>>> "-netdev bridge,br=virbr0,id=br -device rtl8139,netdev=br" if all I want
>>>>>> is something I can ssh into.
>>>>>>
>>>>>> It's easy to deprecate things.  It's hard to convince users that it's
>>>>>> worth, and you haven't convinced this user. :)
> 
> Just another idea before we drop this topic again completely: What if
> we'd extend "-netdev" to be easier to use, too. For example, if you'd
> just specify "-netdev bridge,br=virbr0", without using an id and without
> specifying a "-device", you would get the netdev hooked up to the
> board's default NIC automatically. That would be even less to type than
> your example with "-net" since you would not need the "-net nic"
> parameter in that case... Would it then be ok to deprecate the "-net"
> option?

Actually that would be the worst of both worlds. :)  The point of
-netdev is exactly to have no magic, to be a direct connection between
the command line and the devices.  It makes sense, it's just not too
user friendly.

I really think that if you move -net to net/netlegacy.c it wouldn't look
bad at all.

Paolo

  reply	other threads:[~2015-12-16  8:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 11:46 [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options Thomas Huth
2015-12-15 12:51 ` Paolo Bonzini
2015-12-15 16:01   ` Thomas Huth
2015-12-15 16:21     ` Paolo Bonzini
2015-12-15 16:46       ` Eric Blake
2015-12-15 17:15       ` Thomas Huth
2015-12-15 17:31         ` Paolo Bonzini
2015-12-15 17:50           ` Thomas Huth
2015-12-15 18:08             ` Paolo Bonzini
2015-12-16  7:20               ` Thomas Huth
2015-12-16  8:50                 ` Paolo Bonzini [this message]
2015-12-15 16:17   ` Peter Maydell
2015-12-15 16:33     ` Thomas Huth
2015-12-15 16:46       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567125DD.7050500@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.