All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Dmitry Andreev <dandreev@virtuozzo.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state
Date: Wed, 16 Dec 2015 12:50:02 +0300	[thread overview]
Message-ID: <567133CA.7030603@openvz.org> (raw)
In-Reply-To: <5671304F.3020902@redhat.com>

On 12/16/2015 12:35 PM, Paolo Bonzini wrote:
>
> On 16/12/2015 10:32, Denis V. Lunev wrote:
>>>>
>>>> 'virsh reset' command is usually used to force guest reset. The
>>>> expectation
>>>> of the behavior of this command is that the guest will be force
>>>> restarted.
>>>> This is not true at the moment.
>>> Does "virsh reset" + "virsh continue" work, and if not why?
>> as far as I can see there is no such command in virsh at all :(
> Right, it's "virsh resume". :)
>
> Paolo

actually it does not.

'virsh resume' does not emit command to trigger qmp_cont
in this state. With manual 'virsh qemu-monitor event {"execute": "cont"}'
it starts to work.

Do you propose to kludge libvirt and send 'continue' unconditionally
before a 'reset'? We can but there is not much sense not to implement
this is libvirt due to 'unconditionality'...

Sending command in 'crashed' state only is a bit racy. The event
moving domain into 'crashed' state could be not processed at
the moment.

Den

  reply	other threads:[~2015-12-16  9:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16  9:00 [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state Denis V. Lunev
2015-12-16  9:12 ` Paolo Bonzini
2015-12-16  9:32   ` Denis V. Lunev
2015-12-16  9:35     ` Paolo Bonzini
2015-12-16  9:50       ` Denis V. Lunev [this message]
2015-12-16  9:37     ` Peter Krempa
2015-12-16  9:50   ` Peter Krempa
2015-12-16  9:55     ` Denis V. Lunev
2015-12-16 12:02     ` Paolo Bonzini
2015-12-16 14:47       ` Denis V. Lunev
2016-01-11 10:31         ` Denis V. Lunev
2016-01-11 11:29           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567133CA.7030603@openvz.org \
    --to=den@openvz.org \
    --cc=armbru@redhat.com \
    --cc=dandreev@virtuozzo.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.