From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API Date: Wed, 16 Dec 2015 16:37:39 +0200 Message-ID: <56717733.7070105@dev.mellanox.co.il> References: <20151207204046.8144.18752.stgit@phlsvslse11.ph.intel.com> <20151207204540.8144.94303.stgit@phlsvslse11.ph.intel.com> <5669940D.4040402@dev.mellanox.co.il> <566EEBE8.8020007@dev.mellanox.co.il> <20151214171440.GC23833@phlsvsds.ph.intel.com> <5671653E.40501@dev.mellanox.co.il> <20151216142224.GA28117@phlsvsds.ph.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151216142224.GA28117-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ira Weiny List-Id: linux-rdma@vger.kernel.org > This patch exists to provide parity for what is in qib. Should we not > have it? If not, why do we have: > > commit 38071a461f0a ("IB/qib: Support the new memory registration API") That was done by me because I saw this in qib and assumed that it was supported. Now that I found out that it isn't, I'd say it should be removed altogether shouldn't it? >>> That doesn't mean it can't be added to rdmavt as a future enhancement >>> though if there is a need. >> >> Well, given that we're trying to consolidate on post send registration >> interface it's kind of a must I'd say. >> >>> Are you asking because soft-roce will need it? >> >> I was asking in general, but in specific soft-roce as a consumer will >> need to support that yes. > > I think it makes sense to revisit when soft-roce comes in, I agree. > since qib/hfi do not need IB_WR_LOCAL_INV. Can you explain? Does qib/hfi have a magic way to invalidate memory regions? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html